Skip to content

Omit the JS sync context if threads are not enabled #74167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 2 commits into from
Aug 19, 2022
Merged

Omit the JS sync context if threads are not enabled #74167

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b54ff
Omit the JS sync context if threads are not enabled
kg Aug 18, 2022
7deab10
define FEATURE_WASM_THREADS if threads are enabled
lambdageek Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
define FEATURE_WASM_THREADS if threads are enabled
  • Loading branch information
@lambdageek
lambdageek committed Aug 19, 2022
commit 7deab107bf8e5998ef5b2265675e335a669f8061
8 changes: 8 additions & 0 deletions ...m.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
<Nullable>enable</Nullable>
</PropertyGroup>

<PropertyGroup>
<FeatureWasmThreads Condition="'$(TargetOS)' == 'browser' and '$(WasmEnableThreads)' == 'true'">true</FeatureWasmThreads>
</PropertyGroup>

<PropertyGroup>
<DefineConstants Condition="'$(FeatureWasmThreads)' == 'true'" >$(DefineConstants);FEATURE_WASM_THREADS</DefineConstants>
</PropertyGroup>

<!-- DesignTimeBuild requires all the TargetFramework Derived Properties to not be present in the first property group. -->
<PropertyGroup>
<TargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)'))</TargetPlatformIdentifier>
Expand Down