Skip to content

[release/7.0-rc1] Disable matching constants for vectors that needs upper half to be save/restore #74192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 4 commits into from
Aug 20, 2022
Merged

[release/7.0-rc1] Disable matching constants for vectors that needs upper half to be save/restore #74192

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d7acc4
Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingCo…
kunalspathak Aug 17, 2022
5cd2c38
Revert "Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMa…
kunalspathak Aug 18, 2022
5cc59cf
Add partial save check
kunalspathak Aug 18, 2022
6490cd0
Use the correct register type
kunalspathak Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use the correct register type
  • Loading branch information
@kunalspathak
kunalspathak authored and github-actions committed Aug 18, 2022
commit 6490cd0f996cfe316107a72f38d11b618945947f
2 changes: 1 addition & 1 deletion src/coreclr/jit/lsra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2723,7 +2723,7 @@ bool LinearScan::isMatchingConstant(RegRecord* physRegRecord, RefPosition* refPo
{
return
#if FEATURE_PARTIAL_SIMD_CALLEE_SAVE
!Compiler::varTypeNeedsPartialCalleeSave(physRegRecord->registerType) &&
!Compiler::varTypeNeedsPartialCalleeSave(physRegRecord->assignedInterval->registerType) &&
#endif
GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());
}
Expand Down