Skip to content

Clean up EH routines #74270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AntonLapounov merged 2 commits into from
Aug 20, 2022
Merged

Clean up EH routines #74270

AntonLapounov merged 2 commits into from
Aug 20, 2022

Conversation

@AntonLapounov
Copy link
Member

@AntonLapounov AntonLapounov commented Aug 19, 2022

  • Use the standard name and type for the second argument of exception handler routines: ULONG… MemoryStackFp -> PVOID pEstablisherFrame.
  • Remove the unused pOriginalContext argument of the FixupDispatcherContext function — it was needed for Itanium only.
  • Remove the unused pEstablisherFrame and pThread arguments of the HandleManagedFault function — only ShouldHandleManagedFault needs them. For now, pretend HandleManagedFault can still return to the caller.
  • Fix comments.

@ghost ghost assigned AntonLapounov Aug 19, 2022
janvorli
janvorli approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

noahfalk
noahfalk approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahfalk
Copy link
Member

noahfalk commented Aug 19, 2022

cc @hoyosjs @mikelle-rogers @mikem8361

@AntonLapounov AntonLapounov merged commit bb2f8e5 into dotnet:main Aug 20, 2022
@AntonLapounov AntonLapounov deleted the CleanUpEHRoutines branch August 20, 2022 06:00
@janvorli janvorli mentioned this pull request Aug 25, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

@janvorli janvorli janvorli approved these changes

Assignees

@AntonLapounov AntonLapounov

Labels

area-ExceptionHandling-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AntonLapounov @noahfalk @janvorli