Skip to content

Use the register of CAST for contained index operator #74275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 12 commits into from
Sep 5, 2022
Merged

Use the register of CAST for contained index operator #74275

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7dd7403
Rename test files
kunalspathak Aug 26, 2022
5a06ce6
Fix index scale for cast
kunalspathak Aug 19, 2022
592fafe
Do not contain index if indir is not containable.
kunalspathak Aug 23, 2022
aae7ba5
Revert "Do not contain index if indir is not containable."
kunalspathak Aug 23, 2022
feb4476
Instead try to contain the LEA
kunalspathak Aug 23, 2022
42875bc
IsSafeToContainMem() check
kunalspathak Aug 23, 2022
2416bda
Do IsSafeToContainMem() only if needed
kunalspathak Aug 26, 2022
a6d5919
Add test case
kunalspathak Aug 26, 2022
85c40cf
Fix merge error
kunalspathak Aug 26, 2022
8e97e94
Merge remote-tracking branch 'origin/main' into index_contained
kunalspathak Aug 27, 2022
512e922
fix the test case
kunalspathak Aug 29, 2022
0f14423
review comment
kunalspathak Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix merge error
  • Loading branch information
@kunalspathak
kunalspathak committed Aug 26, 2022
commit 85c40cf6e70087d1b559ae031efe6bcfb63349f3
3 changes: 1 addition & 2 deletions src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5367,12 +5367,11 @@ bool Lowering::TryCreateAddrMode(GenTree* addr, bool isContainable, GenTree* par
{
if (index->OperIs(GT_CAST) && (scale == 1) && (offset == 0) && varTypeIsByte(targetType))
{
index->AsCast()->CastOp()->ClearContained(); // Uncontain any memory operands.

if (IsSafeToContainMem(parent, index))
{
// Check containment safety against the parent node - this will ensure that LEA with the contained
// index will itself always be contained. We do not support uncontained LEAs with contained indices.
index->AsCast()->CastOp()->ClearContained(); // Uncontain any memory operands.
MakeSrcContained(addrMode, index);
}
}
Expand Down