[release/6.0] Fix leak caused by not disposing the scoped parent service provider #74366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsBackport of #74261 to release/6.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Member
|
CC @davidfowl |
tarekgh
reviewed
Aug 22, 2022
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
eerhardt
reviewed
Aug 22, 2022
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
eerhardt
approved these changes
Aug 22, 2022
tarekgh
added
Servicing-approved
Member
|
approved offline by @SteveMCarroll |
Contributor
|
Approved, signed off, OOB package authoring changes properly added, and the CI cannot get any greener than this. Ready to merge. |
carlossanlop
added a commit
to vseanreesermsft/runtime
that referenced
this pull request
Oct 5, 2022
They were introduced in September in these 3 PRs: - Microsoft.Extensions.DependencyInjection: dotnet#74366 - Microsoft.Extensions.Hosting.WindowsServices: dotnet#74188 - Microsoft.NETCore.Platforms (RIDs): dotnet#74383
carlossanlop
added a commit
that referenced
this pull request
Oct 5, 2022
* Update branding to 6.0.11 * Reseting OOB package authoring changes. They were introduced in September in these 3 PRs: - Microsoft.Extensions.DependencyInjection: #74366 - Microsoft.Extensions.Hosting.WindowsServices: #74188 - Microsoft.NETCore.Platforms (RIDs): #74383 Co-authored-by: Carlos Sanchez <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74261 to release/6.0
/cc @tarekgh
Customer Impact
In Dependency Injection, when retrieving the IServiceProvider service and disposing it, it will not dispose the parent container which causes a memory leak. Users of HubConnection in SignalR already experienced and reported this issue as indicated in the issue #73832
Testing
Have passed all CI and regression tests. And manually confirmed it fixes the memory leak.
Risk
Fairly low risk. The change started to dispose the Service Provider object that is supposed to be disposed. The break here is minimal as no-one supposes to use this disposed object and even users can use this disposed object to create a Singlton service.