Skip to content

[release/7.0-rc1] hold reference to SslContextHandle to prevent crashes #74367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 2 commits into from
Aug 23, 2022
Merged

[release/7.0-rc1] hold reference to SslContextHandle to prevent crashes #74367

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3aecf0
fold reference to SslContextHandle to prevent crashes
wfurt Aug 15, 2022
f7c7cb4
Update src/libraries/Common/src/Interop/Unix/System.Security.Cryptogr…
danmoseley Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/libraries/Common/src/Interop/Unix/System.Security.Cryptogr… 
…aphy.Native/Interop.OpenSsl.cs

Co-authored-by: Stephen Toub <[email protected]>
  • Loading branch information
@danmoseley @stephentoub
2 people authored and github-actions committed Aug 22, 2022
commit f7c7cb4d65b286573de1e9bd9be19b584b6c67f7
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ internal static SafeSslHandle AllocateSslHandle(SslAuthenticationOptions sslAuth
if (cacheSslContext && !string.IsNullOrEmpty(punyCode))
{
sslCtxHandle.TrySetSession(sslHandle, punyCode);
bool ignored = false; // DangerousAddRef will throw on failure
bool ignored = false;
sslCtxHandle.DangerousAddRef(ref ignored);
sslHandle.SslContextHandle = sslCtxHandle;
}
Expand Down