Address suggestions by danmoseley

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarFile.cs

@@ -366,10 +366,10 @@ private static IEnumerable<FileSystemInfo> GetFileSystemEnumerationForCreation(s
                     RecurseSubdirectories = true
                 })
             {
-                ShouldRecursePredicate = IsDirectorySymlink
+                ShouldRecursePredicate = IsNotADirectorySymlink
             };
 
-            static bool IsDirectorySymlink(ref FileSystemEntry entry) => entry.IsDirectory && (entry.Attributes & FileAttributes.ReparsePoint) == 0;
+            static bool IsNotADirectorySymlink(ref FileSystemEntry entry) => entry.IsDirectory && (entry.Attributes & FileAttributes.ReparsePoint) == 0;
         }
 
         // Determines what should be the base path for all the entries when creating an archive.

src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectory.File.Tests.cs

@@ -215,15 +215,14 @@ public void SkipRecursionIntoDirectorySymlinks()
             TarFile.CreateFromDirectory(sourceDirectoryName, destinationArchive, includeBaseDirectory: false);
 
             using FileStream archiveStream = File.OpenRead(destinationArchive);
-            using (TarReader reader = new(archiveStream, leaveOpen: false))
-            {
-                TarEntry entry = reader.GetNextEntry();
-                Assert.NotNull(entry);
-                Assert.Equal("subDirectory/", entry.Name);
-                Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+            using TarReader reader = new(archiveStream, leaveOpen: false);
 
-                Assert.Null(reader.GetNextEntry()); // file.txt should not be found
-            }
+            TarEntry entry = reader.GetNextEntry();
+            Assert.NotNull(entry);
+            Assert.Equal("subDirectory/", entry.Name);
+            Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+
+            Assert.Null(reader.GetNextEntry()); // file.txt should not be found
         }
 
         [Fact]
@@ -245,15 +244,14 @@ public void SkipRecursionIntoBaseDirectorySymlink()
             TarFile.CreateFromDirectory(sourceDirectoryName, destinationArchive, includeBaseDirectory: true); // Base directory is a symlink, do not recurse
 
             using FileStream archiveStream = File.OpenRead(destinationArchive);
-            using (TarReader reader = new(archiveStream, leaveOpen: false))
-            {
-                TarEntry entry = reader.GetNextEntry();
-                Assert.NotNull(entry);
-                Assert.Equal("baseDirectory/", entry.Name);
-                Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+            using TarReader reader = new(archiveStream, leaveOpen: false);
 
-                Assert.Null(reader.GetNextEntry());
-            }
+            TarEntry entry = reader.GetNextEntry();
+            Assert.NotNull(entry);
+            Assert.Equal("baseDirectory/", entry.Name);
+            Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+
+            Assert.Null(reader.GetNextEntry());
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectoryAsync.File.Tests.cs

@@ -259,15 +259,14 @@ public async Task SkipRecursionIntoDirectorySymlinksAsync()
             await TarFile.CreateFromDirectoryAsync(sourceDirectoryName, destinationArchive, includeBaseDirectory: false);
 
             await using FileStream archiveStream = File.OpenRead(destinationArchive);
-            await using (TarReader reader = new(archiveStream, leaveOpen: false))
-            {
-                TarEntry entry = await reader.GetNextEntryAsync();
-                Assert.NotNull(entry);
-                Assert.Equal("subDirectory/", entry.Name);
-                Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+            await using TarReader reader = new(archiveStream, leaveOpen: false);
 
-                Assert.Null(await reader.GetNextEntryAsync()); // file.txt should not be found
-            }
+            TarEntry entry = await reader.GetNextEntryAsync();
+            Assert.NotNull(entry);
+            Assert.Equal("subDirectory/", entry.Name);
+            Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+
+            Assert.Null(await reader.GetNextEntryAsync()); // file.txt should not be found
         }
 
         [Fact]
@@ -289,15 +288,14 @@ public async Task SkipRecursionIntoBaseDirectorySymlinkAsync()
             await TarFile.CreateFromDirectoryAsync(sourceDirectoryName, destinationArchive, includeBaseDirectory: true); // Base directory is a symlink, do not recurse
 
             await using FileStream archiveStream = File.OpenRead(destinationArchive);
-            await using (TarReader reader = new(archiveStream, leaveOpen: false))
-            {
-                TarEntry entry = await reader.GetNextEntryAsync();
-                Assert.NotNull(entry);
-                Assert.Equal("baseDirectory/", entry.Name);
-                Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+            await using TarReader reader = new(archiveStream, leaveOpen: false);
 
-                Assert.Null(await reader.GetNextEntryAsync()); // subDirectory should not be found
-            }
+            TarEntry entry = await reader.GetNextEntryAsync();
+            Assert.NotNull(entry);
+            Assert.Equal("baseDirectory/", entry.Name);
+            Assert.Equal(TarEntryType.SymbolicLink, entry.EntryType);
+
+            Assert.Null(await reader.GetNextEntryAsync()); // subDirectory should not be found
         }
     }
 }