Skip to content

[mini] double quote linker path in defined(LD_NAME) case #74451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Aug 24, 2022
Merged

[mini] double quote linker path in defined(LD_NAME) case #74451

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41c4f26
[mini] double quote linker path in defined(LD_NAME) case
lambdageek Aug 23, 2022
39f4bc7
also add an "llvm_only" branch to the defined(LD_NAME) case
lambdageek Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[mini] double quote linker path in defined(LD_NAME) case 
In
e71a958
we started setting a default `LD_NAME` for x86 non-mach targets

Fixes Android x86 builds that specify a `tool_prefix` with spaces in it
  • Loading branch information
@lambdageek
lambdageek committed Aug 23, 2022
commit 41c4f26229bd3ba169726c7e8e2d7c9c32c5d566
2 changes: 1 addition & 1 deletion src/mono/mono/mini/aot-compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12737,7 +12737,7 @@ compile_asm (MonoAotCompile *acfg)
if (ld_binary_name == NULL) {
ld_binary_name = LD_NAME;
}
g_string_append_printf (str, "%s%s %s", tool_prefix, ld_binary_name, LD_OPTIONS);
g_string_append_printf (str, "\"%s%s\" %s", tool_prefix, ld_binary_name, LD_OPTIONS);
#else
if (ld_binary_name == NULL) {
ld_binary_name = "ld";
Expand Down