[release/7.0] Fix write barriers in NativeAOT #74455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jeffschwMSFT
approved these changes
Aug 23, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. We can merge once we have a green ci.
carlossanlop
approved these changes
Aug 24, 2022
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Approved and signed off.
CI is green.
Ready to merge. 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74325 to release/7.0
/cc @AntonLapounov
Customer Impact
The server GC mode for NativeAOT-compiled apps is broken on Linux and Windows ARM64 due to write barriers never updating the card table. Applications crash at random places. In particular, that affects our own crossgen2 compiler.
Testing
Risk
The changes in this PR are effectively ARM64 only. The rest is either under
#ifdef WRITE_BARRIER_CHECK, which is not defined by official builds, or for architectures we do not support at present (x86, ARM32).