Skip to content

Throw on incompatible WebSocket options #74473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 4 commits into from
Sep 2, 2022
Merged

Throw on incompatible WebSocket options #74473

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcc51fc
Throw on incompatible WebSocket options
MihaZupan Sep 1, 2022
d7c4f6c
Don't set ServerCertificateCustomValidationCallback on Browser
MihaZupan Sep 1, 2022
ba64941
Update exception messages
MihaZupan Sep 1, 2022
fc5d996
Skip new H2 test on Browser
MihaZupan Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't set ServerCertificateCustomValidationCallback on Browser
  • Loading branch information
@MihaZupan
MihaZupan committed Sep 1, 2022
commit d7c4f6cb24482dbb0a5c83a60f3ae053522e49c5
8 changes: 5 additions & 3 deletions src/libraries/System.Net.WebSockets.Client/tests/ClientWebSocketTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,12 @@ protected static async Task<WebSocketReceiveResult> ReceiveEntireMessageAsync(We

internal HttpMessageInvoker? GetInvoker()
{
var handler = new HttpClientHandler
var handler = new HttpClientHandler();

if (PlatformDetection.IsNotBrowser)
{
ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator
};
handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
}

ConfigureCustomHandler?.Invoke(handler);

Expand Down