Add NuGet package for System.Runtime.Serialization.Schema #74533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.Runtime.Serialization.Schema isn't getting a NuGet package created for it because it doesn't set IsPackable=true.
carlossanlop
approved these changes
Aug 24, 2022
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Approving, but I'd like @ViktorHofer or @ericstj to also please confirm that this is the expected thing to do for a new nuget package in main.
This will have to be backported to release/7.0-rc1 and release/7.0.
Member
Author
|
CI failures are unrelated. |
eerhardt
deleted the
eerhardt-System.Runtime.Serialization.Schema-packable
branch
Contributor
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2928410261 |
Member
|
@dotnet/area-infrastructure-libraries this is the second instance of this problem in 7.0. We could avoid this by making folks set some property (or opt out) to define how they ship. I would expect every src project to be part of a shared framework, package, or explicitly set a property to indicate it isn’t shipping. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Runtime.Serialization.Schema isn't getting a NuGet package created for it because it doesn't set IsPackable=true.