[release/7.0] [mini] Disable passing valuetypes in SIMD registers #74592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
Member
|
attn @marek-safar |
Contributor
|
@marek-safar can we get an approval? |
SamMonoRT
approved these changes
Aug 25, 2022
Contributor
|
It seems the CI failure is #69853 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74582 to release/7.0
/cc @lambdageek
Partially reverts #68991
When LLVM code calls non-LLVM code it will pass arguments in SIMD
registers which the non-LLVM code doesn't expect
Fixes #73454 (issue 1)
Customer Impact
Customer code that uses
Vector128<T>and other SIMD valuetypes can be used in configurations that use LLVM to compile some code and use non-LLVM AOT or the JIT for other code.Testing
CI
Risk
Low - this reverts the SIMD register calling convention support in managed-to-managed calls, bringing us back to the capabilities we had before net7
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.