Skip to content

[release/7.0] Fix signature for 64-bit delegate profiling helper #74743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Aug 29, 2022
Merged

[release/7.0] Fix signature for 64-bit delegate profiling helper #74743

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2269c49
Fix signature for 64-bit delegate profiling helper
jakobbotsch Aug 24, 2022
f6255cd
JIT: Randomly collect 64-bit counts
jakobbotsch Aug 24, 2022
5f8be23
Disable collecting 64 bit counters on 32-bit
jakobbotsch Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix signature for 64-bit delegate profiling helper 
I missed updating the signature of the 64-bit variant here when the
vtable and delegate profiling helpers were originally split up.

Fix #74295
  • Loading branch information
@jakobbotsch
jakobbotsch authored and github-actions committed Aug 29, 2022
commit 2269c4921ae7bc950bef5a2974e0568f842386f4
2 changes: 1 addition & 1 deletion src/coreclr/vm/jithelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5571,7 +5571,7 @@ HCIMPL2(void, JIT_DelegateProfile32, Object *obj, ICorJitInfo::HandleHistogram32
HCIMPLEND

// Version of helper above used when the count is 64-bit
HCIMPL3(void, JIT_DelegateProfile64, Object *obj, CORINFO_METHOD_HANDLE baseMethod, ICorJitInfo::HandleHistogram64* methodProfile)
HCIMPL2(void, JIT_DelegateProfile64, Object *obj, ICorJitInfo::HandleHistogram64* methodProfile)
{
FCALL_CONTRACT;
FC_GC_POLL_NOT_NEEDED();
Expand Down