Skip to content

[SocketException]: New Constructor with string? for SocketException #74744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liveans merged 8 commits into from
Sep 7, 2022
Merged

[SocketException]: New Constructor with string? for SocketException #74744

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ae4530c
API: Constructor with string? for SocketException
liveans Aug 29, 2022
86a7f92
Update: Review changes
liveans Aug 29, 2022
523ad8a
Update: ExtendedSocketException deleted, added few tests
liveans Aug 30, 2022
6194440
Update: Moving files from Internals to Sockets section in Common
liveans Sep 2, 2022
c0bd4ba
Update: Review changes
liveans Sep 2, 2022
21edab2
Update: A little fix
liveans Sep 2, 2022
3617875
Update: Move test into async section
liveans Sep 5, 2022
2e4924e
Update: Review changes
liveans Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update: A little fix
  • Loading branch information
@liveans
liveans committed Sep 2, 2022
commit 21edab2b0143472717ff7ed5351c631a29060504
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Net/Sockets/SocketExceptionFactory.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public static SocketException CreateSocketException(int socketError, EndPoint en
int nativeErr = (int)socketError;

// If an interop error was not found, then don't invoke Info().RawErrno as that will fail with assert.
if (SocketErrorPal.TryGetNativeErrorForSocketError(socketError, out Interop.Error interopErr))
if (SocketErrorPal.TryGetNativeErrorForSocketError((SocketError)socketError, out Interop.Error interopErr))
{
nativeErr = interopErr.Info().RawErrno;
}
Expand Down