Skip to content

Fix Linux armv6 build on runtime-community.yml #74757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Aug 30, 2022
Merged

Fix Linux armv6 build on runtime-community.yml #74757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa529a
Fix Linux armv6 build on runtime-community.yml
akoeplinger Aug 29, 2022
fe0d9d9
Add missing HOST_ARM define to armv6 in configurecompiler.cmake
akoeplinger Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Linux armv6 build on runtime-community.yml 
We only need the `clr.iltools+clr.packages` subset, not all of CoreCLR.

Also fix some dependencies that weren't working for FreeBSD since we missed the local variables. We don't need installer subset conditions here.
  • Loading branch information
@akoeplinger
akoeplinger committed Aug 29, 2022
commit 9fa529ada8d05fc0400c08b13de8362c92ba9bec
12 changes: 8 additions & 4 deletions eng/pipelines/runtime-community.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ jobs:
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
eq(variables['isRollingBuild'], true))
# extra steps, run tests
extraStepsTemplate: /eng/pipelines/libraries/helix.yml
Expand All @@ -89,6 +88,12 @@ jobs:
runtimeFlavor: mono
platforms:
- FreeBSD_x64
variables:
# map dependencies variables to local variables
- name: librariesContainsChange
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ]
- name: monoContainsChange
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ]
jobParameters:
testScope: innerloop
nameSuffix: AllSubsets_Mono
Expand All @@ -98,7 +103,7 @@ jobs:
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true))
eq(variables['isRollingBuild'], true))

#
# Build the whole product using Mono and run libraries tests
Expand All @@ -120,13 +125,12 @@ jobs:
jobParameters:
testScope: innerloop
nameSuffix: AllSubsets_Mono
buildArgs: -s mono+clr+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true
buildArgs: -s mono+clr.iltools+clr.packages+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true
timeoutInMinutes: 120
condition: >-
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
eq(variables['isRollingBuild'], true))
${{ if eq(variables['isRollingBuild'], true) }}:
# extra steps, run tests
Expand Down