Skip to content

[Android] Skip VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest on x64 #74782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steveisok wants to merge 1 commit into from
Closed

[Android] Skip VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest on x64 #74782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ public static partial class PlatformDetection
public static bool IsNetBSD => RuntimeInformation.IsOSPlatform(OSPlatform.Create("NETBSD"));
public static bool IsAndroid => RuntimeInformation.IsOSPlatform(OSPlatform.Create("ANDROID"));
public static bool IsNotAndroid => !IsAndroid;
public static bool IsAndroidX64 => IsAndroid && Is64BitProcess;
Copy link
Member

@mdh1418 mdh1418 Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be IsX64Process? If its just Android X64? Is64BitProcess would apply to both X64 and Arm64 right

Copy link
Member

@mdh1418 mdh1418 Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus it would be more akin to the IsAndroidX86 right below

Copy link
Member Author

@steveisok steveisok Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. Good catch!

public static bool IsNotAndroidX64 => !IsAndroidX64;
public static bool IsAndroidX86 => IsAndroid && IsX86Process;
public static bool IsNotAndroidX86 => !IsAndroidX86;
public static bool IsiOS => RuntimeInformation.IsOSPlatform(OSPlatform.Create("IOS"));
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ public void VectorSingleEqualsNaNTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74781", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroidX64))]
public void VectorDoubleEqualsNonCanonicalNaNTest()
{
// max 8 bit exponent, just under half max mantissa
Expand All @@ -872,6 +873,7 @@ public void VectorDoubleEqualsNonCanonicalNaNTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74781", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroidX64))]
public void VectorSingleEqualsNonCanonicalNaNTest()
{
// max 11 bit exponent, just under half max mantissa
Expand Down