Change TarWriter exception for unwritable stream to ArgumentException…

…, adjust docs and tests.

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.cs

@@ -25,6 +25,8 @@ public sealed partial class TarWriter : IDisposable, IAsyncDisposable
         /// </summary>
         /// <param name="archiveStream">The stream to write to.</param>
         /// <remarks>When using this constructor, <see cref="TarEntryFormat.Pax"/> is used as the default format of the entries written to the archive using the <see cref="WriteEntry(string, string?)"/> method.</remarks>
+        /// <exception cref="ArgumentNullException"><paramref name="archiveStream"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentException"><paramref name="archiveStream"/> is unwritable.</exception>
         public TarWriter(Stream archiveStream)
             : this(archiveStream, TarEntryFormat.Pax, leaveOpen: false)
         {
@@ -35,6 +37,8 @@ public TarWriter(Stream archiveStream)
         /// </summary>
         /// <param name="archiveStream">The stream to write to.</param>
         /// <param name="leaveOpen"><see langword="false"/> to dispose the <paramref name="archiveStream"/> when this instance is disposed; <see langword="true"/> to leave the stream open.</param>
+        /// <exception cref="ArgumentNullException"><paramref name="archiveStream"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentException"><paramref name="archiveStream"/> is unwritable.</exception>
         public TarWriter(Stream archiveStream, bool leaveOpen = false)
             : this(archiveStream, TarEntryFormat.Pax, leaveOpen)
         {
@@ -50,15 +54,15 @@ public TarWriter(Stream archiveStream, bool leaveOpen = false)
         /// <see langword="true"/> to leave the stream open. The default is <see langword="false"/>.</param>
         /// <remarks>The recommended format is <see cref="TarEntryFormat.Pax"/> for its flexibility.</remarks>
         /// <exception cref="ArgumentNullException"><paramref name="archiveStream"/> is <see langword="null"/>.</exception>
-        /// <exception cref="IOException"><paramref name="archiveStream"/> is unwritable.</exception>
+        /// <exception cref="ArgumentException"><paramref name="archiveStream"/> is unwritable.</exception>
         /// <exception cref="ArgumentOutOfRangeException"><paramref name="format"/> is either <see cref="TarEntryFormat.Unknown"/>, or not one of the other enum values.</exception>
         public TarWriter(Stream archiveStream, TarEntryFormat format = TarEntryFormat.Pax, bool leaveOpen = false)
         {
             ArgumentNullException.ThrowIfNull(archiveStream);
 
             if (!archiveStream.CanWrite)
             {
-                throw new IOException(SR.IO_NotSupported_UnwritableStream);
+                throw new ArgumentException(SR.IO_NotSupported_UnwritableStream);
             }
 
             if (format is not TarEntryFormat.V7 and not TarEntryFormat.Ustar and not TarEntryFormat.Pax and not TarEntryFormat.Gnu)
@@ -210,7 +214,7 @@ private async Task ReadFileFromDiskAndWriteToArchiveStreamAsEntryAsync(string fu
         /// </list>
         /// </remarks>
         /// <exception cref="ObjectDisposedException">The archive stream is disposed.</exception>
-        /// <exception cref="InvalidOperationException">The entry type of the <paramref name="entry"/> is not supported for writing.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="entry"/> is <see langword="null"/>.</exception>
         /// <exception cref="IOException">An I/O problem occurred.</exception>
         public void WriteEntry(TarEntry entry)
         {
@@ -251,7 +255,7 @@ public void WriteEntry(TarEntry entry)
         /// </list>
         /// </remarks>
         /// <exception cref="ObjectDisposedException">The archive stream is disposed.</exception>
-        /// <exception cref="InvalidOperationException">The entry type of the <paramref name="entry"/> is not supported for writing.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="entry"/> is <see langword="null"/>.</exception>
         /// <exception cref="IOException">An I/O problem occurred.</exception>
         public Task WriteEntryAsync(TarEntry entry, CancellationToken cancellationToken = default)
         {

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.Tests.cs

@@ -63,8 +63,8 @@ public void Constructors_UnwritableStream_Throws()
         {
             using MemoryStream archiveStream = new MemoryStream();
             using WrappedStream wrappedStream = new WrappedStream(archiveStream, canRead: true, canWrite: false, canSeek: false);
-            Assert.Throws<IOException>(() => new TarWriter(wrappedStream));
-            Assert.Throws<IOException>(() => new TarWriter(wrappedStream, TarEntryFormat.V7));
+            Assert.Throws<ArgumentException>(() => new TarWriter(wrappedStream));
+            Assert.Throws<ArgumentException>(() => new TarWriter(wrappedStream, TarEntryFormat.V7));
         }
 
         [Fact]