Skip to content

Revert change in StringBuilder.Append(char) #74885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 1 commit into from
Sep 1, 2022
Merged

Revert change in StringBuilder.Append(char) #74885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert change in StringBuilder.Append(char) 
The change has a bad interaction with inlining heuristics.

Fixes #74158. Partial revert of #67448.
  • Loading branch information
@jkotas
jkotas committed Aug 31, 2022
commit 64ea0dbcec450ae0ee8d83b177a77da05dde3da1
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Text/StringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,10 +1052,10 @@ public StringBuilder Append(char value)
int nextCharIndex = m_ChunkLength;
char[] chars = m_ChunkChars;

if ((uint)nextCharIndex < (uint)chars.Length)
if ((uint)chars.Length > (uint)nextCharIndex)
{
chars[nextCharIndex] = value;
m_ChunkLength = nextCharIndex + 1;
m_ChunkLength++;
}
else
{
Expand Down