Apply suggestions from code review

Co-authored-by: David Cantú <[email protected]>

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.cs

@@ -376,7 +376,7 @@ private static void ValidateEntryLinkName(TarEntryType entryType, string? linkNa
             {
                 if (string.IsNullOrEmpty(linkName))
                 {
-                    throw new InvalidDataException(SR.TarEntryHardLinkOrSymlinkLinkNameEmpty);
+                    throw new ArgumentException(SR.TarEntryHardLinkOrSymlinkLinkNameEmpty, "entry");
                 }
             }
         }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.Entry.Gnu.Tests.cs

@@ -243,7 +243,7 @@ public void Write_LinkEntry_EmptyLinkName_Throws(TarEntryType entryType)
         {
             using MemoryStream archiveStream = new MemoryStream();
             using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            Assert.Throws<InvalidDataException>(() => writer.WriteEntry(new GnuTarEntry(entryType, "link")));
+            Assert.Throws<ArgumentException>(() => writer.WriteEntry(new GnuTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.Entry.Pax.Tests.cs

@@ -493,7 +493,7 @@ public void Write_LinkEntry_EmptyLinkName_Throws(TarEntryType entryType)
         {
             using MemoryStream archiveStream = new MemoryStream();
             using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            Assert.Throws<InvalidDataException>(() => writer.WriteEntry(new PaxTarEntry(entryType, "link")));
+            Assert.Throws<ArgumentException>(() => writer.WriteEntry(new PaxTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.Entry.Ustar.Tests.cs

@@ -160,7 +160,7 @@ public void Write_LinkEntry_EmptyLinkName_Throws(TarEntryType entryType)
         {
             using MemoryStream archiveStream = new MemoryStream();
             using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            Assert.Throws<InvalidDataException>(() => writer.WriteEntry(new UstarTarEntry(entryType, "link")));
+            Assert.Throws<ArgumentException>(() => writer.WriteEntry(new UstarTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.Entry.V7.Tests.cs

@@ -100,7 +100,7 @@ public void Write_LinkEntry_EmptyLinkName_Throws(TarEntryType entryType)
         {
             using MemoryStream archiveStream = new MemoryStream();
             using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            Assert.Throws<InvalidDataException>(() => writer.WriteEntry(new V7TarEntry(entryType, "link")));
+            Assert.Throws<ArgumentException>(() => writer.WriteEntry(new V7TarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntryAsync.Entry.Gnu.Tests.cs

@@ -264,7 +264,7 @@ public async Task Write_LinkEntry_EmptyLinkName_Throws_Async(TarEntryType entryT
         {
             await using MemoryStream archiveStream = new MemoryStream();
             await using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            await Assert.ThrowsAsync<InvalidDataException>(async () => await writer.WriteEntryAsync(new GnuTarEntry(entryType, "link")));
+            await Assert.ThrowsAsync<ArgumentException>(async () => await writer.WriteEntryAsync(new GnuTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntryAsync.Entry.Pax.Tests.cs

@@ -513,7 +513,7 @@ public async Task Write_LinkEntry_EmptyLinkName_Throws_Async(TarEntryType entryT
         {
             await using MemoryStream archiveStream = new MemoryStream();
             await using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            await Assert.ThrowsAsync<InvalidDataException>(async () => await writer.WriteEntryAsync(new PaxTarEntry(entryType, "link")));
+            await Assert.ThrowsAsync<ArgumentException>(async () => await writer.WriteEntryAsync(new PaxTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntryAsync.Entry.Ustar.Tests.cs

@@ -161,7 +161,7 @@ public async Task Write_LinkEntry_EmptyLinkName_Throws_Async(TarEntryType entryT
         {
             await using MemoryStream archiveStream = new MemoryStream();
             await using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            await Assert.ThrowsAsync<InvalidDataException>(async () => await writer.WriteEntryAsync(new UstarTarEntry(entryType, "link")));
+            await Assert.ThrowsAsync<ArgumentException>(async () => await writer.WriteEntryAsync(new UstarTarEntry(entryType, "link")));
         }
     }
 }

src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntryAsync.Entry.V7.Tests.cs

@@ -101,7 +101,7 @@ public async Task Write_LinkEntry_EmptyLinkName_Throws_Async(TarEntryType entryT
         {
             await using MemoryStream archiveStream = new MemoryStream();
             await using TarWriter writer = new TarWriter(archiveStream, leaveOpen: false);
-            await Assert.ThrowsAsync<InvalidDataException>(async () => await writer.WriteEntryAsync(new V7TarEntry(entryType, "link")));
+            await Assert.ThrowsAsync<ArgumentException>(async () => await writer.WriteEntryAsync(new V7TarEntry(entryType, "link")));
         }
     }
 }