[release/7.0] Change some exception types thrown in Tar APIs#74893

Merged

carlossanlop merged 17 commits intorelease/7.0from

backport/pr-74845-to-release/7.0

Sep 2, 2022

Commits on Aug 31, 2022

Throw ArgumentException on unsupported tar entry type

carlossanlop
authored and
github-actions
committed
Adjust tests

carlossanlop
authored and
github-actions
committed
Also change exception type for internal TarEntry conversion constructor called by all other public conversion constructors. Add missing test gap.

carlossanlop
authored and
github-actions
committed
LinkName setter null check.

carlossanlop
authored and
github-actions
committed
Internal constructors SeekableSubReadStream and SubReadStream unseekable exception should be ArgumentException.

carlossanlop
authored and
github-actions
committed
DataStream setter for regular file should throw ArgumentException if passed an unreadable stream.

carlossanlop
authored and
github-actions
committed
TarFile CreateFromDirectory unwritable destination change exception to ArgumentException.

carlossanlop
authored and
github-actions
committed
Change to ArgumentException when ExtractToDirectory is an unreadable stream. Add missing exception docs.

carlossanlop
authored and
github-actions
committed
Add some missing exception docs for TarEntry.

carlossanlop
authored and
github-actions
committed
Change TarReader constructor exception if unreadable stream. Close test gap.

carlossanlop
authored and
github-actions
committed
Change TarWriter exception for unwritable stream to ArgumentException, adjust docs and tests.

carlossanlop
authored and
github-actions
committed
Add missing documentation for exceptions in constructors.

carlossanlop
authored and
github-actions
committed
Change wording of conversion constructors comment when passing a Pax GEA entry.

carlossanlop
authored and
github-actions
committed
Apply suggestions by Jozkee

carlossanlop
authored and
github-actions
committed
Add exception to LinkName if the entry type is hard/symlink and the user tries to set an empty string. Add tests.

carlossanlop
authored and
github-actions
committed
Convert all FormatException to InvalidDataException

carlossanlop
authored and
github-actions
committed
Address more suggestions

carlossanlop
authored and
github-actions
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/7.0] Change some exception types thrown in Tar APIs#74893

[release/7.0] Change some exception types thrown in Tar APIs#74893
carlossanlop merged 17 commits intorelease/7.0from
backport/pr-74845-to-release/7.0

Commits on Aug 31, 2022

Throw ArgumentException on unsupported tar entry type

Adjust tests

Also change exception type for internal TarEntry conversion constructor called by all other public conversion constructors. Add missing test gap.

LinkName setter null check.

Internal constructors SeekableSubReadStream and SubReadStream unseekable exception should be ArgumentException.

DataStream setter for regular file should throw ArgumentException if passed an unreadable stream.

TarFile CreateFromDirectory unwritable destination change exception to ArgumentException.

Change to ArgumentException when ExtractToDirectory is an unreadable stream. Add missing exception docs.

Add some missing exception docs for TarEntry.

Change TarReader constructor exception if unreadable stream. Close test gap.

Change TarWriter exception for unwritable stream to ArgumentException, adjust docs and tests.

Add missing documentation for exceptions in constructors.

Change wording of conversion constructors comment when passing a Pax GEA entry.

Apply suggestions by Jozkee

Add exception to LinkName if the entry type is hard/symlink and the user tries to set an empty string. Add tests.

Convert all FormatException to InvalidDataException

Address more suggestions