Skip to content

[release/7.0] [Android][libs] Introduce DateTimeOffset.Now temporary fast result #74965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 22 commits into from
Sep 12, 2022
Merged

[release/7.0] [Android][libs] Introduce DateTimeOffset.Now temporary fast result #74965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2af813a
Avoid ICU loading via StringComparison.Ordinal
mdh1418 Aug 1, 2022
2b068d0
Pass OffsetDateTime and monotonic clock through monovm
mdh1418 Aug 11, 2022
1cdcdc1
WIP Leverage monovm_initialize_preparsed
mdh1418 Aug 11, 2022
188acf1
Initial perf improvement implementation
mdh1418 Aug 11, 2022
5a2197e
Cleanup GetLocalUtcOffset
mdh1418 Aug 18, 2022
f4b3963
Remove Kernel Monotonic Time app context key
mdh1418 Aug 23, 2022
1f37efe
Cleanup GetLocalUtcOffset
mdh1418 Aug 23, 2022
1b1b61a
Sleep background thread first, then start loading AndroidTZData
mdh1418 Aug 24, 2022
8a928df
Conform Runtime Config Property name
mdh1418 Aug 24, 2022
7e67389
Revert "WIP Leverage monovm_initialize_preparsed"
mdh1418 Aug 25, 2022
f85b518
Address feedback
mdh1418 Aug 25, 2022
16ea40f
Fix thread clearing
mdh1418 Aug 26, 2022
564f523
Move implementation to DateTimeOffset.Now
mdh1418 Aug 26, 2022
8f4abd0
Address feedback
mdh1418 Aug 31, 2022
2520363
Consolidate into DateTimeOffset.Now and avoid calling DateTime.UtcNow…
mdh1418 Aug 31, 2022
821d87c
Introduce small performance gains
mdh1418 Sep 1, 2022
c0a6c24
Bump boolean flag outside of background thread body
mdh1418 Sep 1, 2022
1088724
Feedback
Sep 7, 2022
a9034d2
More feedback
Sep 9, 2022
eb5a67c
Move thread block into CompareExchange
Sep 9, 2022
21231f6
Move the AppContext check up
Sep 9, 2022
e611215
Feedback
Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Conform Runtime Config Property name
  • Loading branch information
@mdh1418
mdh1418 authored and github-actions committed Sep 1, 2022
commit 8a928dfad02024330ed0a6061af68813a82459e9
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Unix.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ internal static TimeSpan GetLocalUtcOffset(DateTime dateTime, TimeZoneInfoOption
}
}

object? localDateTimeOffset = AppContext.GetData("LOCAL_DATE_TIME_OFFSET");
object? localDateTimeOffset = AppContext.GetData("System.TimeZoneInfo.LocalDateTimeOffset");
if (localDateTimeOffset == null)
return GetCacheLocalUtcOffset(dateTime, flags); // If no offset property provided through monovm app context, default

Expand Down
2 changes: 1 addition & 1 deletion src/tasks/AndroidAppBuilder/Templates/monodroid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ mono_droid_runtime_init (const char* executable, int managed_argc, char* managed
const char* appctx_keys[3];
appctx_keys[0] = "RUNTIME_IDENTIFIER";
appctx_keys[1] = "APP_CONTEXT_BASE_DIRECTORY";
appctx_keys[2] = "LOCAL_DATE_TIME_OFFSET";
appctx_keys[2] = "System.TimeZoneInfo.LocalDateTimeOffset";

const char* appctx_values[3];
appctx_values[0] = ANDROID_RUNTIME_IDENTIFIER;
Expand Down