Skip to content

[release/7.0] [ARM64] - IsValidCompareChain should return false if both operands are not integral types #75016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 4 commits into from
Sep 2, 2022
Merged

[release/7.0] [ARM64] - IsValidCompareChain should return false if both operands are not integral types #75016

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20dbd5c
IsValidCompareChain should return 'false' if both operands are not in…
TIHan Aug 31, 2022
cd5289c
Add integral type checks in ContainCheckCompareChain
TIHan Aug 31, 2022
ae7b13a
Check if op is CMP or AND
TIHan Aug 31, 2022
2e41061
feedback
TIHan Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check if op is CMP or AND
  • Loading branch information
@TIHan
TIHan authored and github-actions committed Sep 2, 2022
commit ae7b13a0805b1a008fcd506a8feaf020ac456c8e
4 changes: 2 additions & 2 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2122,8 +2122,8 @@ bool Lowering::ContainCheckCompareChain(GenTree* child, GenTree* parent, GenTree
return true;
}
// Can the child be contained.
else if (IsSafeToContainMem(parent, child) && varTypeIsIntegral(child->gtGetOp1()) &&
varTypeIsIntegral(child->gtGetOp2()))
else if (IsSafeToContainMem(parent, child) && (child->OperIs(GT_AND) || child->OperIsCmpCompare()) &&
varTypeIsIntegral(child->gtGetOp1()) && varTypeIsIntegral(child->gtGetOp2()))
{
if (child->OperIs(GT_AND))
{
Expand Down