Skip to content

Tar: Fix buffer is too small error when writing Prefix on large filenames #75023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jozkee wants to merge 9 commits into from
Closed

Tar: Fix buffer is too small error when writing Prefix on large filenames #75023

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e32acb8
Fix WritePosixName to use a correct size buffer
jozkee Sep 2, 2022
7df093d
Address feedback
jozkee Sep 2, 2022
f9666b5
Enable test for Windows, add CanExtractWithTarTool, and use pax archi…
jozkee Sep 7, 2022
99a7381
Look for tar in PATH on all OSes
jozkee Sep 7, 2022
7366e0b
Add try-catch to CanExtractWithTarTool and move GetFileSystemInfosRec…
jozkee Sep 7, 2022
1b4bf33
Skip symlink tests when they are not supported.
jozkee Sep 8, 2022
f666873
Fix CI issues
jozkee Sep 8, 2022
aab4ead
Just skip symlink on windows nano
jozkee Sep 8, 2022
3b02c6e
Exclude Linux_bionic
jozkee Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Look for tar in PATH on all OSes
  • Loading branch information
@jozkee
jozkee committed Sep 7, 2022
commit 99a7381de3472d4477b861793eb53ca14210aaf0
4 changes: 2 additions & 2 deletions src/libraries/System.Formats.Tar/tests/TarTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ public static IEnumerable<object[]> GetPaxAndGnuTestCaseNames()
private static bool CanExtractWithTarTool_Method()
{
using Process tarToolProcess = new Process();
tarToolProcess.StartInfo.FileName = OperatingSystem.IsWindows() ? "tar" : "/usr/bin/tar";
tarToolProcess.StartInfo.FileName = "tar"; // location varies: find it on the PATH.
tarToolProcess.StartInfo.Arguments = "--help";

tarToolProcess.StartInfo.RedirectStandardOutput = true;
Expand All @@ -633,7 +633,7 @@ private static bool CanExtractWithTarTool_Method()
public static void ExtractWithTarTool(string source, string destination)
{
using Process tarToolProcess = new Process();
tarToolProcess.StartInfo.FileName = OperatingSystem.IsWindows() ? "tar" : "/usr/bin/tar";
tarToolProcess.StartInfo.FileName = "tar"; // location varies: find it on the PATH.
tarToolProcess.StartInfo.Arguments = $"-xf {source} -C {destination}";
Copy link
Contributor

@carlossanlop carlossanlop Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an additional boolean parameter isCompressed to this ExtractWithTarTool method. If true, then the arguments could include the z letter, which is used to extract *.tar.gz files.

We would just have to adjust line 271 of the ResultingArchive_CanBeExtractedByOtherTools test method, so that it takes a variable CompressionMethod.

Copy link
Member Author

@jozkee jozkee Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that should be part of the TODOs about adding more variants of this test.


tarToolProcess.StartInfo.RedirectStandardOutput = true;
Expand Down