-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding)
#75063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
61f6a17
Don't ignore mode in IFloatingPoint.Round(TSelf, MipointRounding) DIM
blokyk 296c25b
Fix recursion in IExponentialFunctions.Exp10M1's DIM
blokyk f6a2bac
Merge branch 'dotnet:main' into fix-round-dim
blokyk 27d262c
Merge branch 'main' of https://github.com/dotnet/runtime
blokyk a94e654
Add tests for IExponentialFunctions.Exp10M1's DIM
blokyk 21a14b4
Add tests for IFloatingPoint.Round's DIM
blokyk bbd95ae
fix nits from tannergooding
blokyk c275d00
Merge branch 'dotnet:main' into fix-round-dim
blokyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add tests for IExponentialFunctions.Exp10M1's DIM
- Loading branch information
commit a94e65464aa4daca0506a09f5606bf6eb01f1f83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/libraries/System.Runtime/tests/System/Numerics/IExponentialFunctionsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Xunit; | ||
|
|
||
| namespace System.Numerics.Tests | ||
| { | ||
| public sealed class IExponentialFunctionsTests | ||
| { | ||
| const float baseValue = 2.1f; | ||
| static readonly ExponentialFunctionsDimHelper helperValue = new ExponentialFunctionsDimHelper(baseValue); | ||
|
|
||
| [Fact] | ||
| public static void Exp10M1Test() | ||
| { | ||
| Assert.Equal(Single.Exp10M1(baseValue), ExponentialFunctionsHelper<ExponentialFunctionsDimHelper>.Exp10M1(helperValue).Value); | ||
tannergooding marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.