Skip to content

[release/7.0] Remove duplicate SourceGeneration generator refs #75128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Sep 6, 2022
Merged

[release/7.0] Remove duplicate SourceGeneration generator refs #75128

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c68c0ab
Remove duplicate SourceGeneration generator refs
ViktorHofer Sep 5, 2022
4f8de2c
Update System.Net.Http.csproj
ViktorHofer Sep 5, 2022
d6b627d
Update System.Net.WebSockets.Client.csproj
ViktorHofer Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove duplicate SourceGeneration generator refs 
Unblocks #75058

The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
  • Loading branch information
@ViktorHofer
ViktorHofer authored and github-actions committed Sep 6, 2022
commit c68c0ab790d539b91f1708642beaa3b64215464b
1 change: 0 additions & 1 deletion src/libraries/System.Console/src/System.Console.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@
</ItemGroup>
<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'Browser'">
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime.InteropServices.JavaScript\gen\JSImportGenerator\JSImportGenerator.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime.InteropServices\gen\Microsoft.Interop.SourceGeneration\Microsoft.Interop.SourceGeneration.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
<Reference Include="System.Runtime.InteropServices.JavaScript" />
</ItemGroup>
</Project>