Skip to content

[release/7.0] add ability to set GCName via runtimeconfig. #75159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Sep 9, 2022
Merged

[release/7.0] add ability to set GCName via runtimeconfig. #75159

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28351e0
add ability to set GCName via runtimeconfig.
mangod9 Aug 30, 2022
3c306b7
Update config name.
mangod9 Aug 31, 2022
c717790
Added the GC Name to the gcconfig.h to show up in the GetConfiguratio…
mrsharm Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add ability to set GCName via runtimeconfig.
  • Loading branch information
@mangod9
mangod9 authored and github-actions committed Sep 6, 2022
commit 28351e0ecbd00ebc411ffde85410d0322fd6fb9e
6 changes: 3 additions & 3 deletions src/coreclr/vm/gcheaputilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

#include "common.h"
#include "configuration.h"
#include "gcheaputilities.h"
#include "gcenv.ee.h"
#include "appdomain.hpp"
Expand Down Expand Up @@ -179,7 +180,7 @@ HMODULE LoadStandaloneGc(LPCWSTR libFileName)
//
// See Documentation/design-docs/standalone-gc-loading.md for details
// on the loading protocol in use here.
HRESULT LoadAndInitializeGC(LPWSTR standaloneGcLocation)
HRESULT LoadAndInitializeGC(LPCWSTR standaloneGcLocation)
{
LIMITED_METHOD_CONTRACT;

Expand Down Expand Up @@ -334,8 +335,7 @@ HRESULT GCHeapUtilities::LoadAndInitialize()
assert(g_gc_load_status == GC_LOAD_STATUS_BEFORE_START);
g_gc_load_status = GC_LOAD_STATUS_START;

LPWSTR standaloneGcLocation = nullptr;
CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_GCName, &standaloneGcLocation);
LPCWSTR standaloneGcLocation = Configuration::GetKnobStringValue(W("System.GC.GCName"), CLRConfig::EXTERNAL_GCName);
if (!standaloneGcLocation)
{
return InitializeDefaultGC();
Expand Down