Skip to content

Make System.Transactions.Local trimmable on Windows #75176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 7 commits into from
Sep 9, 2022
Merged

Make System.Transactions.Local trimmable on Windows #75176

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f7ce68
Make System.Transactions.Local trimmable on Windows
eerhardt Sep 7, 2022
1a577f7
Leave the ILLink warning in the product code so app developers get a …
eerhardt Sep 7, 2022
5e7e286
Update src/libraries/System.Transactions.Local/src/System/Transaction…
eerhardt Sep 7, 2022
e8ee202
Add more DynamicDependencies to make trimming work
eerhardt Sep 7, 2022
b01ba13
PR feedback
eerhardt Sep 7, 2022
c909e17
Remove the DynamicDependencies attributes
eerhardt Sep 8, 2022
9dc116d
Fix x86 build. Move the ILLink suppression to a method that is comple…
eerhardt Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the DynamicDependencies attributes 
This gives a better message to users that distributed transactions don't work with trimming.
  • Loading branch information
@eerhardt
eerhardt committed Sep 8, 2022
commit c909e176ebc5b32c3d2abbdcc372c1a69a0b4392
30 changes: 0 additions & 30 deletions ...ies/System.Transactions.Local/src/System/Transactions/DtcProxyShim/DtcProxyShimFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,36 +48,6 @@ private static extern void DtcGetTransactionManagerExW(
[MarshalAs(UnmanagedType.Interface)] out ITransactionDispenser ppvObject);

[RequiresUnreferencedCode("Distributed transactions support may not be compatible with trimming. If your program creates a distributed transaction via System.Transactions, the correctness of the application cannot be guaranteed after trimming.")]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IConnectionPoint))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IConnectionPointContainer))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IEnumConnectionPoints))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IEnumConnections))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IPrepareInfo))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IResourceManager))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IResourceManagerFactory2))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(IResourceManagerSink))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITmNodeName))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransaction))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionCloner))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionDispenser))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionEnlistmentAsync))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionExport))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionExportFactory))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionImport))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionImportWhereabouts))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionOptions))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionOutcomeEvents))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionPhase0EnlistmentAsync))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionPhase0Factory))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionPhase0NotifyAsync))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionReceiver))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionReceiverFactory))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionResourceAsync))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionTransmitter))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionTransmitterFactory))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionVoterBallotAsync2))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionVoterFactory2))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(ITransactionVoterNotifyAsync2))]
private static void DtcGetTransactionManager(string? nodeName, out ITransactionDispenser localDispenser) =>
DtcGetTransactionManagerExW(nodeName, null, Guids.IID_ITransactionDispenser_Guid, 0, null, out localDispenser);

Expand Down