Skip to content

[release/7.0] load msquic early to avoid interference with RemoteExecutor #75466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 4 commits into from
Sep 12, 2022
Merged

[release/7.0] load msquic early to avoid interference with RemoteExecutor #75466

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df91af5
load quic early
wfurt Sep 11, 2022
2bc3178
feedback from review
wfurt Sep 12, 2022
81e6c4f
Update src/libraries/System.Net.Requests/tests/QuicLoad.cs
jkotas Sep 12, 2022
3186a89
Update src/libraries/System.Net.Requests/tests/QuicLoad.cs
jkotas Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feedback from review
  • Loading branch information
@wfurt
wfurt authored and github-actions committed Sep 12, 2022
commit 2bc317810ee2e6fd9b637c0441b5356bb2d358ff
17 changes: 0 additions & 17 deletions src/libraries/Common/tests/System/Net/Capability.Quic.cs
View file
Open in desktop

This file was deleted.

22 changes: 22 additions & 0 deletions src/libraries/System.Net.Requests/tests/QuicLoad.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Net.Quic;
using System.Runtime.CompilerServices;


namespace System.Net.Test.Common
{
public static class QuicLoad
{
[ModuleInitializer]
internal static void InitializeQuic()
{
// This will load Quic (if supported) to avoid interference with RemoteExecutor
// See https://github.com/dotnet/runtime/pull/75424 for more details
// IsSupported currently does not unload lttng. If it does in the future,
// we may need to call some real Quic API here to get everything loaded properly
_ = QuicConnection.IsSupported && QuicListener.IsSupported;
}
}
}
7 changes: 2 additions & 5 deletions src/libraries/System.Net.Requests/tests/System.Net.Requests.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,15 @@
<NoWarn>$(NoWarn);SYSLIB0014</NoWarn>
<!-- the res/xml/network_security_config.xml file comes from the System.Net.TestData package -->
<IncludeNetworkSecurityConfig Condition="'$(TargetOS)' == 'Android'">true</IncludeNetworkSecurityConfig>
<EnablePreviewFeatures>true</EnablePreviewFeatures>
</PropertyGroup>
<ItemGroup>
<AssemblyAttribute Include="System.Runtime.Versioning.RequiresPreviewFeaturesAttribute" />
</ItemGroup>
<ItemGroup>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="HttpWebRequestTest.cs" />
<Compile Include="HttpWebResponseTest.cs" />
<Compile Include="QuicLoad.cs" />
<Compile Include="RequestStreamTest.cs" />
<Compile Include="WebRequestTest.cs" />
<Compile Include="$(CommonTestPath)System\Net\Capability.Quic.cs"
Link="Common\System\Net\Capability.Quic.cs" />
<Compile Include="$(CommonTestPath)System\Net\Capability.Security.cs"
Link="Common\System\Net\Capability.Security.cs" />
<Compile Include="$(CommonTestPath)System\Net\Configuration.cs"
Expand Down