Skip to content

[wasm][debugger] Indexing with expression #75524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 5 commits into from
Sep 14, 2022
Merged

[wasm][debugger] Indexing with expression #75524

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be1b5e0
Support for simple mathematical expressions + tests.
ilonatommy Sep 13, 2022
1bda9a9
A bit more complex expressions.
ilonatommy Sep 13, 2022
efc0159
Applied @radical's suggestions.
ilonatommy Sep 13, 2022
e600ec2
[wasm][debugger] Add another test for EvaluateIndexingByExpressionCon…
radical Sep 14, 2022
646cdb4
[wasm][debugger] Add a broken case of indexing with string accessor
radical Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
A bit more complex expressions.
  • Loading branch information
@ilonatommy
ilonatommy committed Sep 13, 2022
commit 1bda9a942529a400c89371875460dc3d9ff2b6f8
3 changes: 2 additions & 1 deletion src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,7 @@ public async Task EvaluateIndexingByExpression() => await CheckInspectLocalsAtBr

await EvaluateOnCallFrameAndCheck(id,
("f.numList[i + 1]", TNumber(2)),
("f.textList[(2 * j) - 1]", TString("2")),
("f.textList[j - 1]", TString("1")),
("f.numArray[f.numList[j - 1]]", TNumber(2))
);
Expand All @@ -653,7 +654,7 @@ public async Task EvaluateIndexingByExpressionMultidimensional() => await CheckI
await EvaluateOnCallFrameAndCheck(id,
("f.numArray2D[0, j - 1]", TNumber(1)), // 0, 0
("f.numArray2D[f.idx1, i + j]", TNumber(4)), // 1, 1
("f.numArray2D[f.idx1 - j, i + j]", TNumber(2)), // 0, 1
("f.numArray2D[(f.idx1 - j) * 5, i + j]", TNumber(2)), // 0, 1
("f.numArray2D[i + j, f.idx1 - 1]", TNumber(3)) // 1, 0
);
});
Expand Down