Skip to content

[wasm][debugger] fixing setting a breakpoint in an invalid IL offset after hotreload #75561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 6 commits into from
Sep 14, 2022
Merged

[wasm][debugger] fixing setting a breakpoint in an invalid IL offset after hotreload #75561

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
994ad0d
fixing setting a breakpoint in an invalid IL offset
thaystg Sep 13, 2022
b65917d
addressing @radical comments
thaystg Sep 13, 2022
6eeccfd
Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
thaystg Sep 13, 2022
7112b51
Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
thaystg Sep 13, 2022
64e86ef
addressing @radical comments
thaystg Sep 13, 2022
2ce1a1b
addressing @radical comments
thaystg Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs 
Co-authored-by: Ankit Jain <[email protected]>
  • Loading branch information
@thaystg @radical
thaystg and radical authored Sep 13, 2022
commit 7112b51135cd55eb4139090d68326ec6fbbf864a
2 changes: 1 addition & 1 deletion src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@ public async Task<int> SetBreakpointNoThrow(int methodId, long il_offset, Cancel
commandParamsWriter.Write((byte)ModifierKind.LocationOnly);
commandParamsWriter.Write(methodId);
commandParamsWriter.Write(il_offset);
using var retDebuggerCmdReader = await SendDebuggerAgentCommand(CmdEventRequest.Set, commandParamsWriter, token, false);
using var retDebuggerCmdReader = await SendDebuggerAgentCommand(CmdEventRequest.Set, commandParamsWriter, token, throwOnError: false);
if (retDebuggerCmdReader.HasError)
return -1;
return retDebuggerCmdReader.ReadInt32();
Expand Down