Fix missing flags for IND(str_handle) #75576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #75562 Also, fix cc @AndyAyersMS
|
EgorBo
commented
Sep 14, 2022
AndyAyersMS
approved these changes
Sep 14, 2022
jakobbotsch
reviewed
Sep 14, 2022
jakobbotsch
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75562
Normally, we set
GTF_IND_INVARIANTfor string literals when we create IND nodes representing them, but after #49576GTF_ICON_STR_HDLmay be created withoutGT_INDfirst, so if it appears later - update its flags.Also, fix
eeGetCPString(used for e.g. DOTNET_JitDisasm) to handle frozen stringscc @AndyAyersMS