Fix Configuration.Binder for collection properties with no setters #75689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding to an IDictionary/ICollection/ISet in ConfigurationBinder with no setter was failing because we were returning too early. Only returning early now if we were able to set the property, or if the interface is read-only. Fix dotnet#75626
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBinding to an IDictionary/ICollection/ISet in ConfigurationBinder with no setter was failing because we were returning too early. Only returning early now if we were able to set the property, or if the interface is read-only. Fix #75626 fyi @SteveDunn - this looks like another regression from #68133
|
tarekgh
approved these changes
Sep 15, 2022
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
LGTM, thanks for getting this fixed quickly.
Contributor
|
Thanks for such a quick fix @eerhardt ! |
Nick-Stanton
approved these changes
Sep 15, 2022
maryamariyan
approved these changes
Sep 15, 2022
Member
Author
|
/backport to release/7.0-rc2 |
Contributor
|
Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3063957068 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding to an IDictionary/ICollection/ISet in ConfigurationBinder with no setter was failing because we were returning too early.
Only returning early now if we were able to set the property, or if the interface is read-only.
Fix #75626
fyi @SteveDunn - this looks like another regression from #68133