Only R2R public methods, methods that override public methods, and internal methods that aren't always inlined #75793
Only R2R methods that are either publicly exposed or (to make sure we…
… cover all of the methods in CoreLib used by the runtime) any embedded linker xml root files.
- Loading branch information
commit d583b6c982f5bb873752fd449a83b83b8bedf722
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Diagnostics; | ||
| using System.Reflection; | ||
| using Internal.TypeSystem; | ||
| using Internal.TypeSystem.Ecma; | ||
|
|
||
| namespace ILCompiler | ||
| { | ||
| public enum EffectiveVisibility | ||
| { | ||
| Private, | ||
| Public, | ||
| Family, | ||
| Assembly, | ||
| FamilyAndAssembly, | ||
| FamilyOrAssembly, | ||
| } | ||
|
|
||
| public static class EffectiveVisibilityExtensions | ||
| { | ||
| private static EffectiveVisibility ToEffectiveVisibility(this TypeAttributes typeAttributes) | ||
| { | ||
| return (typeAttributes & TypeAttributes.VisibilityMask) switch | ||
| { | ||
| TypeAttributes.Public or TypeAttributes.NestedPublic => EffectiveVisibility.Public, | ||
| TypeAttributes.NotPublic => EffectiveVisibility.Assembly, | ||
| TypeAttributes.NestedPrivate => EffectiveVisibility.Private, | ||
| TypeAttributes.NestedAssembly => EffectiveVisibility.Assembly, | ||
| TypeAttributes.NestedFamily => EffectiveVisibility.Family, | ||
| TypeAttributes.NestedFamANDAssem => EffectiveVisibility.FamilyAndAssembly, | ||
| TypeAttributes.NestedFamORAssem => EffectiveVisibility.FamilyOrAssembly, | ||
| _ => throw new UnreachableException() | ||
| }; | ||
| } | ||
| private static EffectiveVisibility ToEffectiveVisibility(this MethodAttributes typeAttributes) | ||
| { | ||
| return (typeAttributes & MethodAttributes.MemberAccessMask) switch | ||
| { | ||
| MethodAttributes.Public => EffectiveVisibility.Public, | ||
| MethodAttributes.Private => EffectiveVisibility.Private, | ||
| MethodAttributes.Assembly => EffectiveVisibility.Assembly, | ||
| MethodAttributes.Family => EffectiveVisibility.Family, | ||
| MethodAttributes.FamANDAssem => EffectiveVisibility.FamilyAndAssembly, | ||
| MethodAttributes.FamORAssem => EffectiveVisibility.FamilyOrAssembly, | ||
| _ => throw new UnreachableException() | ||
| }; | ||
| } | ||
|
|
||
| private static EffectiveVisibility ConstrainToVisibility(this EffectiveVisibility visibility, EffectiveVisibility enclosingVisibility) | ||
| { | ||
| return (visibility, enclosingVisibility) switch | ||
| { | ||
| (_, _) when visibility == enclosingVisibility => visibility, | ||
| (_, EffectiveVisibility.Private) => EffectiveVisibility.Private, | ||
| (EffectiveVisibility.Private, _) => EffectiveVisibility.Private, | ||
| (EffectiveVisibility.Public, _) => enclosingVisibility, | ||
| (_, EffectiveVisibility.Public) => visibility, | ||
| (EffectiveVisibility.FamilyOrAssembly, _) => enclosingVisibility, | ||
| (_, EffectiveVisibility.FamilyOrAssembly) => visibility, | ||
| (EffectiveVisibility.Family, EffectiveVisibility.Assembly) => EffectiveVisibility.FamilyAndAssembly, | ||
| (EffectiveVisibility.Family, EffectiveVisibility.FamilyAndAssembly) => EffectiveVisibility.FamilyAndAssembly, | ||
| (EffectiveVisibility.Assembly, EffectiveVisibility.Family) => EffectiveVisibility.FamilyAndAssembly, | ||
| (EffectiveVisibility.Assembly, EffectiveVisibility.FamilyAndAssembly) => EffectiveVisibility.FamilyAndAssembly, | ||
| (EffectiveVisibility.FamilyAndAssembly, EffectiveVisibility.Family) => EffectiveVisibility.FamilyAndAssembly, | ||
| (EffectiveVisibility.FamilyAndAssembly, EffectiveVisibility.Assembly) => EffectiveVisibility.FamilyAndAssembly, | ||
| _ => throw new UnreachableException(), | ||
| }; | ||
| } | ||
|
|
||
| public static bool IsExposedOutsideOfThisAssembly(this EffectiveVisibility visibility, bool anyInternalsVisibleTo) | ||
| { | ||
| return visibility is EffectiveVisibility.Public or EffectiveVisibility.Family | ||
| || (anyInternalsVisibleTo && visibility is EffectiveVisibility.Assembly or EffectiveVisibility.FamilyOrAssembly); | ||
| } | ||
|
|
||
| public static EffectiveVisibility GetEffectiveVisibility(this EcmaMethod method) | ||
| { | ||
| EffectiveVisibility visibility = method.Attributes.ToEffectiveVisibility(); | ||
|
|
||
| for (EcmaType type = (EcmaType)method.OwningType; type is not null; type = (EcmaType)type.ContainingType) | ||
| { | ||
| visibility = visibility.ConstrainToVisibility(type.Attributes.ToEffectiveVisibility()); | ||
| } | ||
| return visibility; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should inline this logic to where it's needed (or into an extension method). It doesn't look like we need to cache this and metadata reader + handle is available as a public API on
EcmaType.