Skip to content

Add the ability to start and stop IHostedService instances concurrently #75894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerryk414 wants to merge 11 commits into from
Closed

Add the ability to start and stop IHostedService instances concurrently #75894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f17c035
Stop IHostedService instances asynchronously by default
jerryk414 Apr 19, 2022
3798699
Add missing refs; add unit tests; ensure stop behavior cannot be chan…
jerryk414 May 6, 2022
8d804b4
Merge branch 'main' into Stop-IHostedService-instances-asynchronously
jerryk414 May 6, 2022
99986e7
Merge branch 'dotnet:main' into Stop-IHostedService-instances-asynchr…
jerryk414 Jun 24, 2022
e0257b8
Merge branch 'dotnet:main' into Stop-IHostedService-instances-asynchr…
jerryk414 Sep 19, 2022
ff29ba5
Use booleans to determine if both StartAsync and StopAsync should be …
jkrmo Sep 20, 2022
92be997
Add a custom logger message for startup failures
jkrmo Sep 20, 2022
335c576
Fix LogLevel check
jkrmo Sep 20, 2022
fd8a0c7
Semantics
jkrmo Sep 20, 2022
e634a6c
If a single error is thrown, do not wrap it in an aggregate exception.
jkrmo Sep 20, 2022
946a3d4
Fix tests; short-circuit StartAsync on first sequential failure
jkrmo Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests; short-circuit StartAsync on first sequential failure
  • Loading branch information
@jkrmo
jkrmo committed Sep 21, 2022
commit 946a3d4c6f50cfdfe3e75c5767f6c047f42d2f0a
1 change: 1 addition & 0 deletions src/libraries/Microsoft.Extensions.Hosting/src/Internal/Host.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public async Task StartAsync(CancellationToken cancellationToken = default)
catch (Exception ex)
{
exceptions.Add(ex);
break;
}
}
}
Expand Down
84 changes: 62 additions & 22 deletions src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,27 +217,46 @@ public void HostedServiceRegisteredWithFactory()
}
}

[Fact]
public async Task AppCrashesOnStartWhenFirstHostedServiceThrows()
[Theory]
[InlineData(1, true), InlineData(1, false)]
[InlineData(2, true), InlineData(2, false)]
[InlineData(10, true), InlineData(10, false)]
public async Task AppCrashesOnStartWhenFirstHostedServiceThrows(int eventCount, bool concurrentStartup)
{
bool[] events1 = null;
bool[] events2 = null;
bool[][] events = new bool[eventCount][];

using (var host = CreateBuilder()
.ConfigureServices((services) =>
{
events1 = RegisterCallbacksThatThrow(services);
events2 = RegisterCallbacksThatThrow(services);
services.Configure<HostOptions>(i => i.ServicesStartConcurrently = concurrentStartup);

for (int i = 0; i < eventCount; i++)
{
events[i] = RegisterCallbacksThatThrow(services);
}
})
.Build())
{
await Assert.ThrowsAsync<InvalidOperationException>(() => host.StartAsync());
Assert.True(events1[0]);
Assert.False(events2[0]);
if (concurrentStartup && eventCount > 1)
await Assert.ThrowsAsync<AggregateException>(() => host.StartAsync());
else
await Assert.ThrowsAsync<InvalidOperationException>(() => host.StartAsync());

for (int i = 0; i < eventCount; i++)
{
if (i == 0 || concurrentStartup)
Assert.True(events[i][0]);
else
Assert.False(events[i][0]);
}

host.Dispose();

// Stopping
Assert.False(events1[1]);
Assert.False(events2[1]);
for (int i = 0; i < eventCount; i++)
{
Assert.False(events[i][1]);
}
}
}

Expand Down Expand Up @@ -1108,17 +1127,23 @@ public async Task HostDisposeApplicationDoesNotFireStopOnHostedService()
}
}

[Fact]
public async Task HostDoesNotNotifyIHostApplicationLifetimeCallbacksIfIHostedServicesThrow()
[Theory]
[InlineData(1, true), InlineData(1, false)]
[InlineData(2, true), InlineData(2, false)]
[InlineData(10, true), InlineData(10, false)]
public async Task HostDoesNotNotifyIHostApplicationLifetimeCallbacksIfIHostedServicesThrow(int eventCount, bool concurrentStartup)
{
bool[] events1 = null;
bool[] events2 = null;
bool[][] events = new bool[eventCount][];

using (var host = CreateBuilder()
.ConfigureServices((services) =>
{
events1 = RegisterCallbacksThatThrow(services);
events2 = RegisterCallbacksThatThrow(services);
services.Configure<HostOptions>(i => i.ServicesStartConcurrently = concurrentStartup);

for (int i = 0; i < eventCount; i++)
{
events[i] = RegisterCallbacksThatThrow(services);
}
})
.Build())
{
Expand All @@ -1127,13 +1152,28 @@ public async Task HostDoesNotNotifyIHostApplicationLifetimeCallbacksIfIHostedSer
var started = RegisterCallbacksThatThrow(applicationLifetime.ApplicationStarted);
var stopping = RegisterCallbacksThatThrow(applicationLifetime.ApplicationStopping);

await Assert.ThrowsAsync<InvalidOperationException>(() => host.StartAsync());
Assert.True(events1[0]);
Assert.False(events2[0]);
if (concurrentStartup && eventCount > 1)
await Assert.ThrowsAsync<AggregateException>(() => host.StartAsync());
else
await Assert.ThrowsAsync<InvalidOperationException>(() => host.StartAsync());

for (int i = 0; i < eventCount; i++)
{
if (i == 0 || concurrentStartup)
Assert.True(events[i][0]);
else
Assert.False(events[i][0]);
}

Assert.False(started.All(s => s));

host.Dispose();
Assert.False(events1[1]);
Assert.False(events2[1]);

for (int i = 0; i < eventCount; i++)
{
Assert.False(events[i][1]);
}

Assert.False(stopping.All(s => s));
}
}
Expand Down