Skip to content

Update RateLimiting ref assembly #75976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 1 commit into from
Sep 21, 2022
Merged

Update RateLimiting ref assembly #75976

ViktorHofer merged 1 commit into from
Sep 21, 2022

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Sep 21, 2022 •
edited
Loading

Part of #73263

@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BrennanConroy
Assignees: -
Labels:

area-System.Threading
Milestone: -

@ghost
Copy link

ghost commented Sep 21, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned BrennanConroy Sep 21, 2022
ViktorHofer
ViktorHofer approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. I think we also need to backport this into release/7.0 when this is merged and fill in the servicing template.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Sep 21, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3099722367

@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Merged
@BrennanConroy
Copy link
Member Author

BrennanConroy commented Sep 21, 2022

fill in the servicing template.

Do you mind filling this out? I don't know the implications of the change so can't properly comment on it.

@ViktorHofer ViktorHofer merged commit 34c522b into dotnet:main Sep 21, 2022
@ViktorHofer ViktorHofer mentioned this pull request Sep 21, 2022
Merged
@BrennanConroy BrennanConroy deleted the brecon/ref branch September 21, 2022 21:25
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@BrennanConroy BrennanConroy

Labels

area-System.Threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrennanConroy @ViktorHofer