Skip to content

[release/7.0] [NativeAOT] Ensure that frozen objects respect the minimum object size #76050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Sep 26, 2022
Merged

[release/7.0] [NativeAOT] Ensure that frozen objects respect the minimum object size #76050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2460782
Ensure that frozen objects respect the minimum object size
filipnavara Sep 22, 2022
7e81997
Apply feedback
filipnavara Sep 22, 2022
6ac8ebe
Handle FrozenStringNode too
filipnavara Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply feedback
  • Loading branch information
@filipnavara
filipnavara authored and github-actions committed Sep 23, 2022
commit 7e819976cb91ea0b9cafcd8de3e344065927afef
2 changes: 0 additions & 2 deletions src/coreclr/tools/Common/TypeSystem/Common/TargetDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ public int MinimumCodeAlignment
}
}

public int MinimumObjectSize => PointerSize * 3;

public TargetDetails(TargetArchitecture architecture, TargetOS targetOS, TargetAbi abi)
{
Architecture = architecture;
Expand Down
5 changes: 4 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/EETypeNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ public override ObjectNodeSection Section
}
}

public int MinimumObjectSize => _type.Context.Target.MinimumObjectSize;
public int MinimumObjectSize => GetMinimumObjectSize(_type.Context);

public static int GetMinimumObjectSize(TypeSystemContext typeSystemContext)
=> typeSystemContext.Target.PointerSize * 3;

protected virtual bool EmitVirtualSlotsAndInterfaces => false;

Expand Down
9 changes: 9 additions & 0 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/FrozenObjectNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,20 @@ int ISymbolDefinitionNode.Offset

public override void EncodeData(ref ObjectDataBuilder dataBuilder, NodeFactory factory, bool relocsOnly)
{
int initialOffset = dataBuilder.CountBytes;

// Sync Block
dataBuilder.EmitZeroPointer();

// byte contents
_data.WriteContent(ref dataBuilder, this, factory);

int objectSize = dataBuilder.CountBytes - initialOffset;
int minimumObjectSize = EETypeNode.GetMinimumObjectSize(factory.TypeSystemContext);
if (objectSize < minimumObjectSize)
{
dataBuilder.EmitZeros(minimumObjectSize - objectSize);
}
}

protected override string GetName(NodeFactory factory) => this.GetMangledName(factory.NameMangler);
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,7 +2234,6 @@ public ObjectInstance(DefType type, AllocationSite allocationSite)
int size = type.InstanceByteCount.AsInt;
if (type.IsValueType)
size += type.Context.Target.PointerSize;
size = Math.Max(size, type.Context.Target.MinimumObjectSize - type.Context.Target.PointerSize);
_data = new byte[size];
}

Expand Down