Skip to content

Use generated runtime.json when building shared framework packages. #76068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 6 commits into from
Sep 27, 2022
Merged

Use generated runtime.json when building shared framework packages. #76068

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9f12d2
Use generated runtime.json when building shared framework packages.
tmds Sep 23, 2022
4155c27
Don't UpdateRuntimeJson on Build.
tmds Sep 26, 2022
68cb01b
PR feedback.
tmds Sep 26, 2022
6337a64
PR feedback.
tmds Sep 26, 2022
20723ec
PR feedback.
tmds Sep 27, 2022
43e52ad
Update Microsoft.NETCore.Platforms.csproj
ViktorHofer Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't UpdateRuntimeJson on Build.
  • Loading branch information
@tmds
tmds committed Sep 26, 2022
commit 4155c27b1adb25fb04d02fe2c368e8efe5022c17
4 changes: 2 additions & 2 deletions src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

<UsingTask TaskName="GenerateRuntimeGraph" AssemblyFile="$(_generateRuntimeGraphTask)"/>

<Target Name="GenerateRuntimeJson" BeforeTargets="UpdateRuntimeJson">
<Target Name="GenerateRuntimeJson" BeforeTargets="Build">
<MakeDir Directories="$(IntermediateOutputPath)" />
<GenerateRuntimeGraph Condition="'$(AdditionalRuntimeIdentifiers)' != ''"
RuntimeGroups="@(RuntimeGroupWithQualifiers)"
Expand All @@ -69,7 +69,7 @@
DestinationFiles="$(GeneratedRuntimeIdentifierGraphFile)" />
</Target>

<Target Name="UpdateRuntimeJson" BeforeTargets="Build">
<Target Name="UpdateRuntimeJson">
<!-- Generates a Runtime graph using RuntimeGroups and diffs it with the graph described by runtime.json and runtime.compatibility.json
Specifying UpdateRuntimeFiles=true skips the diff and updates those files.
The graph can be visualized using the generated dmgl -->
Expand Down