Skip to content

[release/7.0] backport Tar fixes #76322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 12 commits into from
Oct 4, 2022
Merged

[release/7.0] backport Tar fixes #76322

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
abe6daf
Use UTF8 encoding on Tar string fields
jozkee Sep 20, 2022
646a96b
Slice destination on Checksum
jozkee Sep 20, 2022
90a1f51
Use Encoding.GetByteCount as fast path
jozkee Sep 20, 2022
e4b1c69
Use escape sequences on hardcoded UTF8 characters
jozkee Sep 20, 2022
130bad1
Fix ustar prefix logic and throw if name would be truncated
jozkee Sep 22, 2022
512eb04
Address feedback
jozkee Sep 22, 2022
d774bf0
Fix truncation and prefix logic
jozkee Sep 26, 2022
818ab42
Fix nits
jozkee Sep 27, 2022
ae3a623
Add async tests
jozkee Sep 27, 2022
14571b0
Add tests for unseekable streams
jozkee Sep 27, 2022
a255c73
Address feedback
jozkee Sep 28, 2022
0aa84d2
Tar: Use indexer setter instead of Add on ExtendedAttributes dictiona…
jozkee Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use escape sequences on hardcoded UTF8 characters
  • Loading branch information
@jozkee
jozkee authored and github-actions committed Sep 28, 2022
commit e4b1c692cf85ac18d69dcfa9a282114c8634df50
4 changes: 2 additions & 2 deletions src/libraries/System.Formats.Tar/tests/TarTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public abstract partial class TarTestsBase : FileCleanupTestBase
protected const string PaxEaDevMajor = "devmajor";
protected const string PaxEaDevMinor = "devminor";
internal const char OneByteCharacter = 'a';
internal const char TwoBytesCharacter = 'ö';
internal const string FourBytesCharacter = "😒";
internal const char TwoBytesCharacter = '\u00F6';
internal const string FourBytesCharacter = "\uD83D\uDE12";
internal const char Separator = '/';
internal const int MaxPathComponent = 255;

Expand Down