[PERF] Pass local runtime timestamp from git into ci_setup #76396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the bypassing of calling the github.com api.
…l build job.yml" This reverts commit e810a45. Can't build mono app without the global build job...
|
Tagging subscribers to this area: @hoyosjs Issue Detailsdotnet/performance#2622 adds the ability to pass the timestamp of the runtime commit to ci_setup instead of calling the GitHub API to retrieve it. This will keep us from hitting GitHub API rate limiting during our runs.
|
Member
|
LGTM. Have you run a private run of this? |
Member
Author
|
Yes, the private run successfully ran using this with the performance branch. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/performance#2622 adds the ability to pass the timestamp of the runtime commit to ci_setup instead of calling the GitHub API to retrieve it. This will keep us from hitting GitHub API rate limiting during our runs.