Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 5, 2022

This PR reverts #76235 with a few manual modifications:

  1. JIT-EE guid is re-generated
  2. gen.bat is invoked (ThunkInput.txt)
  3. Crst are re-generated by the tool, changed lock-level to Unordered

The rest of the changes are automatically reverted.

The main issue why the initial PRs (#75573 and #76135) were reverted has just been resolved via #76251

tldr:
GC could collect some associated (with frozen objects) objects as unreachable, e.g. it could collect a SyncBlock, WeakReferences and Dependent handles associated with frozen objects which could (e.g. for a short period of time) be indeed unreachable but return back to life after.

Unblocks #76112

@ghost ghost assigned EgorBo Oct 5, 2022
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 5, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR reverts #76235 with a few manual modifications:

  1. JIT-EE guid is re-generated
  2. gen.bat is invoked (ThunkInput.txt)
  3. Crst are re-generated by the tool, changed lock-level to Unordered
    The rest of the changes are automatically reverted.

The main issue why the initial PRs (#75573 and #76135) were reverted has just been resolved via #76251

tldr:
GC could collect some associated (with frozen objects) objects as unreachable, e.g. it could collect a SyncBlock, WeakReferences and Dependent handles associated with frozen objects which could (e.g. for a short period of time) be indeed unreachable but return back to life after.

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Oct 5, 2022

/azp run runtime-coreclr outerloop, runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@EgorBo EgorBo force-pushed the foh-frozen-types-2 branch from e64a5d5 to ecc25ea Compare October 5, 2022 11:49
@EgorBo EgorBo marked this pull request as ready for review October 5, 2022 17:13
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(I have not reviewed the superpmi files.)

@EgorBo EgorBo merged commit 23bdaa3 into dotnet:main Oct 6, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Oct 6, 2022

SPMI failures are expected (jit-ee guid change)
outerloop/gcstress passed (I assume changes we did for printobject could not brake anything additionally)
Thank you so much for help! 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants