Skip to content

statically linking GC PAL on linux #76985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mangod9 merged 13 commits into from
Oct 25, 2022
Merged

statically linking GC PAL on linux #76985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
41710cb
statically linking GC PAL
mangod9 Oct 13, 2022
61426d7
fixing arm64 and nativeaot build breaks
mangod9 Oct 13, 2022
225f725
macos build break and reducing renaming.
mangod9 Oct 13, 2022
4c54b0a
trying to remove numa support from PAL
mangod9 Oct 15, 2022
c4ac1e7
one more rename to resolve MacOS break
mangod9 Oct 15, 2022
64af4b7
delete pal numa code.
mangod9 Oct 17, 2022
0e90a82
Merge branch 'main' into use_gc_pal
mangod9 Oct 18, 2022
a585fc3
Adding missing madvise in GC PAL
mangod9 Oct 19, 2022
4c53ff8
added missing MADV_DONTDUMP calls.
mangod9 Oct 19, 2022
6d441b7
CR feedback
mangod9 Oct 20, 2022
d6450eb
Merge branch 'main' into use_gc_pal
mangod9 Oct 20, 2022
71a5896
undo (long long) cast in GetMemoryStatus
mangod9 Oct 20, 2022
b6d04a1
only invoke madvise on success.
mangod9 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
undo (long long) cast in GetMemoryStatus
  • Loading branch information
@mangod9
mangod9 committed Oct 20, 2022
commit 71a58961901ebd2ad42568c06fc87f98639825eb
3 changes: 1 addition & 2 deletions src/coreclr/gc/env/gcenv.os.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,7 @@ class GCToOSInterface
// available_page_file - The maximum amount of memory the current process can commit, in bytes.
// Remarks:
// Any parameter can be null.
// explicit (unsigned long long) is used to conform to both Linux and MacOS
static void GetMemoryStatus(unsigned long long restricted_limit, uint32_t* memory_load, unsigned long long* available_physical, unsigned long long* available_page_file);
static void GetMemoryStatus(uint64_t restricted_limit, uint32_t* memory_load, uint64_t* available_physical, uint64_t* available_page_file);

// Get size of an OS memory page
static size_t GetPageSize();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25888,7 +25888,7 @@ void gc_heap::get_memory_info (uint32_t* memory_load,
uint64_t* available_physical,
uint64_t* available_page_file)
{
GCToOSInterface::GetMemoryStatus(is_restricted_physical_mem ? total_physical_mem : 0, memory_load, (unsigned long long*) available_physical, (unsigned long long*) available_page_file);
GCToOSInterface::GetMemoryStatus(is_restricted_physical_mem ? total_physical_mem : 0, memory_load, available_physical, available_page_file);
}

//returns TRUE is an overflow happened.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/gc/unix/gcenv.unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,7 @@ uint64_t GetAvailablePageFile()
// that is in use (0 indicates no memory use and 100 indicates full memory use).
// available_physical - The amount of physical memory currently available, in bytes.
// available_page_file - The maximum amount of memory the current process can commit, in bytes.
void GCToOSInterface::GetMemoryStatus(unsigned long long restricted_limit, uint32_t* memory_load, unsigned long long* available_physical, unsigned long long* available_page_file)
void GCToOSInterface::GetMemoryStatus(uint64_t restricted_limit, uint32_t* memory_load, uint64_t* available_physical, uint64_t* available_page_file)
{
uint64_t available = 0;
uint32_t load = 0;
Expand Down