Skip to content

[PERF] Fix Linux arm64 AOT ROOTFS_DIR missing #77024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LoopedBard3 wants to merge 7 commits into from
Closed

[PERF] Fix Linux arm64 AOT ROOTFS_DIR missing #77024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6be3fb3
Setup testing 1.
LoopedBard3 Oct 13, 2022
6cd30af
Try: Add crossrootfsDir to the crossrootfs directory for arm64.
LoopedBard3 Oct 13, 2022
5f2d7f9
Try to fix yaml stage depends on unknown job.
LoopedBard3 Oct 13, 2022
ce76efa
Try moving crossrootfsDir up a parameter group.
LoopedBard3 Oct 13, 2022
a1fa632
remove jobParameters from the condition for crossrootfsDir.
LoopedBard3 Oct 13, 2022
743b8d8
Try only passing crossrootfsDir into jobParameters.
LoopedBard3 Oct 13, 2022
e46f2be
Undo testing setup.
LoopedBard3 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/common/global-build-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ jobs:
- name: _crossBuildPropertyArg
value: /p:CrossBuild=${{ parameters.crossBuild }}

- ${{ if ne(parameters.jobParameters.crossrootfsDir, '') }}:
- ${{ if ne(parameters.crossrootfsDir, '') }}:
# This is only required for cross builds.
- name: ROOTFS_DIR
value: ${{ parameters.jobParameters.crossrootfsDir }}
value: ${{ parameters.crossrootfsDir }}

- name: _cxx11Parameter
${{ if and(eq(parameters.osGroup, 'Linux'), eq(parameters.archType, 'arm64')) }}:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/perf_slow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ extends:
- Linux_arm64
jobParameters:
buildArgs: -s mono+libs+host+packs -c $(_BuildConfig) /p:MonoEnableLLVM=true /p:MonoBundleLLVMOptimizer=true
crossrootfsDir: '/crossrootfs/arm64'
nameSuffix: AOT
isOfficialBuild: false
extraStepsTemplate: /eng/pipelines/common/upload-artifact-step.yml
Expand Down