Skip to content

Modify __int64 definition in PAL to match the OS definition #77056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 6 commits into from
Oct 18, 2022
Merged

Modify __int64 definition in PAL to match the OS definition #77056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b823cfd
Modify __int64 definition in PAL to match the OS definition
janvorli Oct 14, 2022
92d2787
Fix coreclr tests build
janvorli Oct 14, 2022
4bada87
Fix comment on #endif in jit.h
janvorli Oct 14, 2022
ddafbc2
Reflect PR feedback
janvorli Oct 14, 2022
6d13629
Fix jit source formatting
janvorli Oct 14, 2022
cc99180
Fix FreeBSD build
janvorli Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reflect PR feedback
  • Loading branch information
@janvorli
janvorli committed Oct 14, 2022
commit ddafbc2f525dd90fe407c96a971666e788bd2741
6 changes: 3 additions & 3 deletions src/coreclr/debug/createdump/crashinfounix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,9 @@ CrashInfo::VisitProgramHeader(uint64_t loadbias, uint64_t baseAddress, Phdr* phd
TRACE("VisitProgramHeader: ehFrameHdrStart %016llx ehFrameHdrSize %08llx\n", ehFrameHdrStart, ehFrameHdrSize);
InsertMemoryRegion(ehFrameHdrStart, ehFrameHdrSize);

uint64_t ehFrameStart;
uint64_t ehFrameSize;
if (PAL_GetUnwindInfoSize(baseAddress, ehFrameHdrStart, ReadMemoryAdapter, (ULONG64*)&ehFrameStart, (ULONG64*)&ehFrameSize))
ULONG64 ehFrameStart;
ULONG64 ehFrameSize;
if (PAL_GetUnwindInfoSize(baseAddress, ehFrameHdrStart, ReadMemoryAdapter, &ehFrameStart, &ehFrameSize))
{
TRACE("VisitProgramHeader: ehFrameStart %016llx ehFrameSize %08llx\n", ehFrameStart, ehFrameSize);
if (ehFrameStart != 0 && ehFrameSize != 0)
Expand Down
3 changes: 3 additions & 0 deletions src/coreclr/pal/inc/pal_mstypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,9 @@ typedef unsigned int SIZE_T;
typedef int SSIZE_T;
#endif

static_assert(sizeof(SIZE_T) == sizeof(void*), "SIZE_T should be pointer sized");
static_assert(sizeof(SSIZE_T) == sizeof(void*), "SSIZE_T should be pointer sized");

#ifndef SIZE_T_MAX
#define SIZE_T_MAX ULONG_PTR_MAX
#endif // SIZE_T_MAX
Expand Down