Skip to content

Fix loading app-local ICU #77065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 7 commits into from
Oct 17, 2022
Merged

Fix loading app-local ICU #77065

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2911b8
Fix loading app-local ICU
tarekgh Oct 14, 2022
8607651
Restrict the platforms to run the tests on
tarekgh Oct 15, 2022
299d255
Adjust the test supported platforms
tarekgh Oct 15, 2022
13ce1cb
Test Platforms
tarekgh Oct 15, 2022
ea10dcf
Fix the test OS filtering
tarekgh Oct 16, 2022
563ae4b
address the feedback
tarekgh Oct 16, 2022
66b46f5
More feedback addressing
tarekgh Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust the test supported platforms
  • Loading branch information
@tarekgh
tarekgh committed Oct 15, 2022
commit 299d25503a46eed519e579cfd129888f73c1d4ff
9 changes: 7 additions & 2 deletions src/libraries/System.Globalization/tests/IcuAppLocal/IcuAppLocal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@ namespace System.Globalization.Tests
public class IcuAppLocalTests
{

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.Is64BitProcess))]
[PlatformSpecific(TestPlatforms.Windows | TestPlatforms.Linux)]
private static bool SupportIcuPackageDownload => PlatformDetection.Is64BitProcess &&
PlatformDetection.IsNotOSX &&
PlatformDetection.IsNotMobile &&
!PlatformDetection.IsAlpine &&
!PlatformDetection.IsLinuxBionic;

[ConditionalFact(nameof(SupportIcuPackageDownload))]
public void TestIcuAppLocal()
{
Type? interopGlobalization = Type.GetType("Interop+Globalization, System.Private.CoreLib");
Expand Down