Skip to content

[release/7.0] Fix loading app-local ICU #77118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 8 commits into from
Oct 18, 2022
Merged

[release/7.0] Fix loading app-local ICU #77118

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef7b093
Fix loading app-local ICU
tarekgh Oct 14, 2022
45aa980
Restrict the platforms to run the tests on
tarekgh Oct 15, 2022
1799657
Adjust the test supported platforms
tarekgh Oct 15, 2022
67e3b0a
Test Platforms
tarekgh Oct 15, 2022
1ca32fb
Fix the test OS filtering
tarekgh Oct 16, 2022
130c0b9
address the feedback
tarekgh Oct 16, 2022
8205afd
More feedback addressing
tarekgh Oct 16, 2022
66d4799
Fix the test
tarekgh Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More feedback addressing
  • Loading branch information
@tarekgh
tarekgh authored and github-actions committed Oct 17, 2022
commit 8205afdde967541b16035678c213ee5de8e934aa
2 changes: 1 addition & 1 deletion src/libraries/System.Globalization/tests/IcuAppLocal/IcuAppLocal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public void TestIcuAppLocal()
// the test has to start running first before filtering the test cases and the globalization
// code will run and fail fast at that time.

ProcessStartInfo psi = new ProcessStartInfo() { UseShellExecute = false };
ProcessStartInfo psi = new ProcessStartInfo();
psi.Environment.Add("DOTNET_SYSTEM_GLOBALIZATION_APPLOCALICU", "68.2.0.9");

RemoteExecutor.Invoke(() =>
Expand Down