Skip to content

Fix OCSP test responder to omit fractional seconds #77411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vcsjones merged 1 commit into from
Oct 25, 2022
Merged

Fix OCSP test responder to omit fractional seconds #77411

vcsjones merged 1 commit into from
Oct 25, 2022

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Oct 24, 2022

Closes #77408

@ghost ghost added the area-System.Security label Oct 24, 2022
@ghost ghost assigned vcsjones Oct 24, 2022
@ghost
Copy link

ghost commented Oct 24, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #77408

Author: vcsjones
Assignees: -
Labels:

area-System.Security
Milestone: -

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

Doh. That was the wrong outerloop.

/azp run runtime-libraries-coreclr outerloop

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

S.S.Cryptography outerloop passed. None of the outerloop failures appear related, and this is a test only change. Merging.

@vcsjones vcsjones merged commit f4b715f into dotnet:main Oct 25, 2022
@vcsjones vcsjones deleted the fix-revocation-tests branch October 25, 2022 14:34
@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

@bartonjs should this test-only change be back ported to release/7.0 or release/6.0 so that if/when those pick up Ventura the tests won't start failing?

@vcsjones vcsjones added the test-enhancement Improvements of test source code label Oct 25, 2022
@bartonjs
Copy link
Member

bartonjs commented Oct 25, 2022

Your question has certainly sold me on the value of the backport; and test-only changes are generally taken. So, yes 😄

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3322798204

@vcsjones
Copy link
Member Author

vcsjones commented Oct 25, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3322799106

This was referenced Oct 25, 2022
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees

@vcsjones vcsjones

Labels

area-System.Security test-enhancement Improvements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DynamicRevocationTests fails on macOS 13

2 participants

@vcsjones @bartonjs