[wasm][debugger] Fixing when trying to call mono functions in a non wasm page #77496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @thaystg Issue DetailsI think this will probably fix: After trying a lot to reproduce I realized that on RuntimeReady method, the ClearAllBreakpoints works, but when we try to run the next command on the wasm page, which is the SetProtocolVersion, it's not a wasm page anymore then it throws the exception. In the PR I'm protecting all the messages sent on RuntimeReady, because it's expected an exception there if it's not a wasm page.
|
radical
reviewed
Oct 26, 2022
radical
reviewed
Oct 26, 2022
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3331696964 |
radical
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will probably fix:
#77013
#68402
After trying a lot to reproduce I realized that on RuntimeReady method, the ClearAllBreakpoints works, but when we try to run the next command on the wasm page, which is the SetProtocolVersion, it's not a wasm page anymore then it throws the exception. In the PR I'm protecting all the messages sent on RuntimeReady, because it's expected an exception there if it's not a wasm page.