-
Notifications
You must be signed in to change notification settings - Fork 5.3k
SPMI: Extend list of unrecorded environment variables #77504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakobbotsch
merged 1 commit into
dotnet:main
from
jakobbotsch:spmi-avoid-recording-more-vars
Oct 27, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
SPMI: Extend list of unrecorded environment variables
We are currently hitting issues when there are diffs in the FileCheck tests because they are recorded with JitStdOutFile and the SPMI driver does not override this correctly. Add this and a lot of other environment variables to the list of variables we do not record with. This big list of string compares may look somewhat scary but we only record variables once during startup of the JIT, so it shouldn't be too bad.
- Loading branch information
commit 8e77f8a6c8aa9950825c71677d0dae3eba7506ae
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that
DOTNET_JitNameandDOTNET_AltJitNamedo not come through this path since the JIT doesn't query them. So they don't need to be here.