Skip to content

[hot_reload] implement param reflection #77563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 15 commits into from
Nov 2, 2022
Merged

[hot_reload] implement param reflection #77563

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fa0fbba
Add new test ReflectionAddNewMethod
lambdageek Oct 27, 2022
0458e6a
FIXME: get_param_names, get_marshal_info and custom_attrs need work
lambdageek Oct 27, 2022
bbb5670
WIP - add a method param reverse lookup
lambdageek Oct 27, 2022
c96dec0
look up params from added methods
lambdageek Oct 27, 2022
fe55b74
Remove FIXMEs and unused field
lambdageek Oct 27, 2022
0dcfca6
remove writelines from test
lambdageek Oct 27, 2022
55b2892
fix test on coreclr
lambdageek Oct 27, 2022
b71efae
why does coreclr have 2 attributes here??
lambdageek Oct 28, 2022
d078831
There should be 2 attributes on the 4th param
lambdageek Oct 28, 2022
b1829fb
one more place that looks at params
lambdageek Oct 29, 2022
9d923b2
A couple more places where we look at the Params table
lambdageek Oct 29, 2022
7f89576
Check default values on params on added method
lambdageek Oct 29, 2022
ca45fd4
fix lookup if table is empty
lambdageek Oct 29, 2022
ded76bb
add a gratuitious typeof assert
lambdageek Oct 29, 2022
42e43e5
Add a single mono_metadata_get_method_params function
lambdageek Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
There should be 2 attributes on the 4th param
  • Loading branch information
@lambdageek
lambdageek committed Oct 29, 2022
commit d0788312f1cb2c699ca54efd6a410926022374bc
22 changes: 17 additions & 5 deletions src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using Xunit;

namespace System.Reflection.Metadata
Expand Down Expand Up @@ -684,11 +685,22 @@ public static void TestReflectionAddNewMethod()
parmPos++;
}

foreach (var ca in parms[4].GetCustomAttributes(false)) {
Console.WriteLine (" - parm[4] has {0}", ca);
}
Assert.Equal (1, parms[4].GetCustomAttributes(false).Length);
Assert.Equal (typeof (CallerMemberNameAttribute), parms[4].GetCustomAttributes(false)[0].GetType());
var parmAttrs = parms[4].GetCustomAttributes(false);
Assert.Equal (2, parmAttrs.Length);
bool foundCallerMemberName = false;
bool foundOptional = false;
foreach (var pa in parmAttrs) {
if (typeof (CallerMemberNameAttribute).Equals(pa.GetType()))
{
foundCallerMemberName = true;
}
if (typeof (OptionalAttribute).Equals(pa.GetType()))
{
foundOptional = true;
}
}
Assert.True(foundCallerMemberName);
Assert.True(foundOptional);

// TODO: check the default values of the last two params
});
Expand Down