-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fold bound checks for static readonly arrays/strings #77593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
0fe7042
Initial impl of Jan's suggestions
EgorBo e428363
Address part of the feedback
EgorBo 774af69
Address feedback
EgorBo 28b9be3
Remove "is frozen" check from jit
EgorBo 9f92bfb
NativeAOT support
EgorBo 687d5cb
Use CORINFO_OBJECT_HANDLE in more places
EgorBo 872058d
Free jit handles upon exit
EgorBo 860d706
Update src/coreclr/vm/jitinterface.cpp
EgorBo bffb8e6
Clean up
EgorBo f0a35cc
clean up in getArrayLength
EgorBo bfaf6ee
Update jitinterface.h
EgorBo a3ccc91
Remove unnecessary DestroyHandle
EgorBo 7e041c1
Rename to getArrayOrStringLength, free jit handles in destructor
EgorBo 1bba1ec
fix compilation
EgorBo ee0117e
Use IND instead of LoadVector
EgorBo b20f1fb
Update hwintrinsicxarch.cpp
EgorBo 2a12b10
Update hwintrinsicxarch.cpp
EgorBo 504acf3
Apply suggestions from code review
EgorBo b56a67f
Address feedback
EgorBo 15a39a6
Address feedback
EgorBo 1683f29
Address feedback
EgorBo 43a32c9
Move "Is frozen" check to getJitHandleForObject
EgorBo d10f4eb
Update src/coreclr/vm/jitinterface.cpp
EgorBo 4443383
Update src/coreclr/vm/jitinterface.cpp
EgorBo 429b4d1
use OBJECTREF everywhere
EgorBo 49c32c4
fix bad merge
EgorBo 5dbbef4
Cannonize more loads
EgorBo 62f5cbb
check ISAs
EgorBo a096211
Fix comments
EgorBo efd71e9
Handle stores
EgorBo 27a2619
Fix compilation & address feedback around redundant IsFrozenSegment call
EgorBo 1f95212
Merge branch 'use-ind-for-loads' of github.com:EgorBo/runtime-1 into …
EgorBo d5c3cab
DescriptionDescription -> Description
EgorBo 7621045
Merge branch 'main' of github.com:dotnet/runtime into fold-static-rea…
EgorBo 96397b1
Update valuenum.cpp
EgorBo 076d4cd
Add comments
EgorBo 1ecceca
Merge branch 'main' of github.com:dotnet/runtime into fold-static-rea…
EgorBo 752c840
Revert unrelated SIMD changes (accidentally pushed)
EgorBo ea8e369
Use Exception sets
EgorBo 2fab46b
Address feedback
EgorBo 07d42e5
Address feedback
EgorBo 8c2ec20
Update src/coreclr/jit/valuenum.cpp
EgorBo 93c11c9
Address feedback
EgorBo 19df3e6
Apply suggestions from code review
EgorBo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update valuenum.cpp
- Loading branch information
commit 96397b126c53fb4e1b99826ba8ca45dd97dae75d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.